Achille/dev 0.0.27 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AchilleBailly
commented
Dec 2, 2022
| use DateTime; | ||
| use Exception; | ||
| use OCP\AppFramework\Http; |
There was a problem hiding this comment.
Unused Imports
AchilleBailly
commented
Dec 2, 2022
| $sql = 'SELECT * FROM `*PREFIX*calendars` WHERE `*PREFIX*calendars`.principaluri = ?'; | ||
| return $this->execSQLNoJsonReturn($sql, array($principalUri)); | ||
| } | ||
|
|
There was a problem hiding this comment.
SQL query to get the calendars that belong to the user. Used to select the calendar when adding a new event with the new form.
AchilleBailly
commented
Dec 2, 2022
| if (dtEnd > periodEnd) | ||
| dtEnd = periodEnd | ||
|
|
||
|
|
There was a problem hiding this comment.
Fix to the total count : used to add the full length of an event when the event started in the period but ended after (or the opposit)
AchilleBailly
commented
Dec 2, 2022
| charactersLength)); | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
Moved to utils.js
AchilleBailly
commented
Dec 2, 2022
| 'Astreinte', | ||
| 'Férié', | ||
| 'Total' | ||
| ] |
There was a problem hiding this comment.
No more hard coded values (except first and last columns)
AchilleBailly
commented
Dec 2, 2022
| } | ||
| } | ||
| oReq.send(data) | ||
| return oReq; |
There was a problem hiding this comment.
New XHR functions used in the new form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature
Added a form directly in WAI to create events automatically, formatted just as needed.
HR Summary
ALLOWED_PLACESlist to fill the header of the table instead of the temporary hardcoded values.Refactor