Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mary Tian CS Fun Bipartition Graph #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mary-Tian
Copy link

No description provided.

Copy link

@kyra-patton kyra-patton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐾🐶 Nice work, Mary. I'm marking this as a yellow since the Big O is not filled out. Let me know what questions you have.

🟡

Comment on lines 8 to 9
Time Complexity: ?
Space Complexity: ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱🪐 Time and space complexity?

Comment on lines +20 to +23
if dislikes[0]:
start_node = 0
else:
start_node = 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the edge case where there are multiple disconnected nodes indexed at the beginning of dislikes

For example: `dislikes = [ [], [], [], [1,2] ]

How might you refactor your code to account for this edge case?

visited.add(start_node)
red.add(start_node)

while len(queue) != 0:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩 Nice BFS approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants