Lety Palomo -Pine C-16 Graphs #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jul 23, 2022
There was a problem hiding this comment.
🐾🐶 Your implementation works, but you forgot to add the time and space complexity.
Since the time and space complexity of BFS is a bit different from past functions you may have implemented, we do consider it an essential component to completing this project. Feel free to update your project with the Big O filled out for a green score. Let me know what questions you have.
🟡
graphs/possible_bipartition.py
Outdated
Comment on lines
8
to
9
| Time Complexity: ? | ||
| Space Complexity: ? |
| dog_q=deque() | ||
| for i in range (len(dislikes)): | ||
| if i not in grouped: | ||
| dog_q += [i] |
There was a problem hiding this comment.
🤔 I'm not exactly sure why you are adding i as a list to the queue. It should be sufficient to just add i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.