-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PyInstaller conflicts #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to a0fd126 in 35 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_ujAb8Sru0yH78F26
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
pyproject.toml
Outdated
@@ -39,7 +39,7 @@ pyinstaller = ">=6.6" | |||
types-click = "*" | |||
|
|||
[tool.mypy] | |||
python_version = 3.8 | |||
python_version = "^3.8,<3.14" # PyInstaller needs <3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python_version
field in mypy should specify a single version, not a range. Consider setting it to a specific version like 3.8
.
f96973b
to
de80e98
Compare
Thanks! |
One more issue. The lock file as it is will throw errors with
Running |
Cleaning up all that stuff today, thanks for the report! |
Project specifies a Python version range of >=3.8,<4.0, but PyInstaller requires >=3.8, <3.13 or >=3.8, <3.14 depending on the version.
To avoid the following conflict:
Related to PR ActivityWatch/aw-qt#106.
Important
Update
python_version
inpyproject.toml
to resolve PyInstaller conflicts.python_version
in[tool.mypy]
to^3.8,<3.14
inpyproject.toml
to resolve conflicts with PyInstaller's Python version requirements.This description was created by
for a0fd126. It will automatically update as commits are pushed.