Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alternative firefox name #85

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Jun 13, 2024

this is how awatcher matches it


🚀 This description was created by Ellipsis for commit c563a99

Summary:

Added "org.mozilla.firefox" to browser_appnames in aw_client/queries.py to ensure correct event processing for this Firefox identifier.

Key points:

  • Added "org.mozilla.firefox" to the firefox entry in the browser_appnames dictionary in aw_client/queries.py.
  • Ensures awatcher correctly matches and processes events from Firefox identified as org.mozilla.firefox.

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c563a99 in 37 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_client/queries.py:214
  • Draft comment:
    Adding 'org.mozilla.firefox' to the list of Firefox browser names seems appropriate for ensuring compatibility with environments where Firefox is identified by this name. Please ensure that this addition does not conflict with existing browser identification logic elsewhere in the application.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The PR adds 'org.mozilla.firefox' to the list of Firefox browser names in the browserEvents function. This seems intended to match the browser name as it appears in certain environments or configurations. The change is straightforward and appears to be consistent with the existing structure of the code, where browser names are listed explicitly for matching purposes. It's important to ensure that this new entry does not introduce any inconsistencies or errors in how browser events are fetched and processed.

Workflow ID: wflow_Nh6oMzsYLYhUYxUl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo
Copy link
Member Author

0xbrayo commented Oct 23, 2024

@ErikBjare ping

@ErikBjare ErikBjare merged commit e0b0743 into ActivityWatch:master Oct 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants