Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUR-3978 implement default UI and backend permissions for all default roles of all organizations #1316

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CUR-3978 some changes
  • Loading branch information
Waleed Muhammad committed Sep 23, 2022
commit 826d8ba18aad9a4ec0a0662741c71606a1d496e3
41 changes: 21 additions & 20 deletions database/seeds/OrganizationRoleUiPermissionSeeder.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,19 @@ public function run()

$this->domain = request()->getHttpHost();

foreach ($roleTypes as $roleType) {
if ($roleType->name === 'admin') {
$this->assignPermissions($adminUiPermissions, $roleType);
} else if ($roleType->name === 'course_creator') {
$this->assignPermissions($courseCreatorUiPermissions, $roleType);
} else if ($roleType->name === 'member') {
$this->assignPermissions($memberUiPermissions, $roleType);
} else if ($roleType->name === 'self_registered') {
$this->assignPermissions($selfRegisteredUiPermissions, $roleType);
return DB::transaction(function () use($roleTypes, $adminUiPermissions, $courseCreatorUiPermissions, $memberUiPermissions, $selfRegisteredUiPermissions) {
foreach ($roleTypes as $roleType) {
if ($roleType->name === 'admin') {
$this->assignPermissions($adminUiPermissions, $roleType);
} else if ($roleType->name === 'course_creator') {
$this->assignPermissions($courseCreatorUiPermissions, $roleType);
} else if ($roleType->name === 'member') {
$this->assignPermissions($memberUiPermissions, $roleType);
} else if ($roleType->name === 'self_registered') {
$this->assignPermissions($selfRegisteredUiPermissions, $roleType);
}
}
}
});
}

function assignPermissions($uiPermissions, $roleType)
Expand All @@ -146,18 +148,17 @@ function assignPermissions($uiPermissions, $roleType)
}
}

if (isset($this->uiModules[$permissionName]) && isset($this->uiModulePermissions[$permissionType][$this->uiModules[$permissionName]])) {
$uiModulePermissionIds[] = $this->uiModulePermissions[$permissionType][$this->uiModules[$permissionName]];
$uiPermissionName = $this->uiModules[$permissionName];
if (isset($uiPermissionName) && isset($this->uiModulePermissions[$permissionType][$uiPermissionName])) {
$uiModulePermissionIds[] = $this->uiModulePermissions[$permissionType][$uiPermissionName];
}
}

return DB::transaction(function () use($uiModulePermissionIds, $roleType) {
// assign ui role permissions
$roleType->uiModulePermissions()->sync($uiModulePermissionIds);
// assign backend role permissions
$UiOrganizationPermissionMappingRepository = resolve(UiOrganizationPermissionMappingRepositoryInterface::class);
$organizationPermissionTypeIds = $UiOrganizationPermissionMappingRepository->getOrganizationPermissionTypeIds($uiModulePermissionIds);
$roleType->permissions()->sync($organizationPermissionTypeIds);
});
// assign ui role permissions
$roleType->uiModulePermissions()->sync($uiModulePermissionIds);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use transaction in the seeder.

// assign backend role permissions
$UiOrganizationPermissionMappingRepository = resolve(UiOrganizationPermissionMappingRepositoryInterface::class);
$organizationPermissionTypeIds = $UiOrganizationPermissionMappingRepository->getOrganizationPermissionTypeIds($uiModulePermissionIds);
$roleType->permissions()->sync($organizationPermissionTypeIds);
}
}