Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor for Node20 support #118

Merged
merged 1 commit into from
Oct 1, 2024
Merged

♻️ Refactor for Node20 support #118

merged 1 commit into from
Oct 1, 2024

Conversation

stoe
Copy link
Contributor

@stoe stoe commented Oct 1, 2024

This pull request includes several changes to improve the project's configuration and streamline the setup process. The most important changes involve updates to the ESLint configuration, the CodeQL workflow, and the Husky hooks.

ESLint and Prettier Configuration Updates:

  • Added a new eslint.config.mjs file to replace the old .eslintrc.json configuration, integrating Prettier and additional plugins for better code formatting and linting. (eslint.config.mjs, eslint.config.mjsR1-R32)
  • Removed the old .eslintrc.json file to streamline the ESLint configuration. (.eslintrc.json, .eslintrc.jsonL1-L21)
  • Updated package.json to use the new ESLint configuration file and added new dependencies for ESLint and Prettier. (package.json, [1] [2]
  • Added a new prettier.config.js file to customize Prettier settings. (prettier.config.js, prettier.config.jsR1-R10)

CodeQL Workflow Improvements:

  • Updated the CodeQL workflow to include a new configuration file and adjusted the paths and settings to enhance security analysis. (.github/codeql/codeql-config.yml, [1]; .github/workflows/codeql.yml, [2]

Husky Hooks Reorganization:

  • Moved and updated Husky hooks to a new location to simplify the setup and improve the developer experience. (.husky/pre-commit, [1]; .husky/pre-push, [2]
  • Removed the old Husky pre-commit script to avoid redundancy. (.github/husky/pre-commit, .github/husky/pre-commitL1-L11)

Miscellaneous:

  • Updated .eslintignore and .prettierignore to exclude unnecessary files from linting and formatting. (.eslintignore, [1]; .prettierignore, [2]
  • Removed the old Prettier configuration file. (.prettierrc.js, .prettierrc.jsL1)

These changes collectively aim to improve the project's code quality, streamline the development workflow, and enhance security practices.

@stoe stoe requested a review from a team as a code owner October 1, 2024 07:17
@stoe stoe self-assigned this Oct 1, 2024
@stoe stoe force-pushed the stoe/refactor-node20 branch from 806fb5a to d590450 Compare October 1, 2024 07:24
@stoe stoe enabled auto-merge (squash) October 1, 2024 07:24
@stoe stoe disabled auto-merge October 1, 2024 07:24
@stoe stoe merged commit 7437836 into main Oct 1, 2024
1 of 3 checks passed
@stoe stoe deleted the stoe/refactor-node20 branch October 1, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant