Support for GHC 9.10 #547
Merged
Support for GHC 9.10 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentRDC
commented
Nov 29, 2024
| @@ -14,7 +14,7 @@ | |||
| module Data.BitSet where | |||
|
|
|||
| import Data.Bits | |||
| import Prelude hiding ( foldl, foldr ) | |||
| import Prelude hiding ( foldl, foldr, foldl' ) | |||
There was a problem hiding this comment.
Newly included in the prelude as of GHC 9.10
0544668 to
2e32777
Compare
|
Let's not block this PR on apple clang on macos 14 not supporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for taking the time to create this pull request! You are awesome (:
The following schema may help when filing your pull request:
Description
This pull request adapts
accelerateto be compiled using GHC 9.10, which comes bundled withbase4.20 and, most importantly,template-haskell2.22Motivation and context
Why is this change required? What problem does it solve? If it fixes an open issue(s), link to the issue here.
How has this been tested?
The test suite was run on my local machine using GHC 9.10
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!