Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch changes all cabal flags to
manual
inaccelerate.cabal
.Motivation and context
This prevents Cabal from automatically assigning flags in the constraint solver. This currently cannot result in issues: if any build configuration is valid, the default one is valid too. However, using 'manual' flags makes this future-proof against changes within Accelerate, and also changes within Cabal: with 'manual' we select the semantically correct type of flag.
This should not adversely affect anything, especially since the flags are only meant for Accelerate developers and testers anyway.
How has this been tested?
Accelerate still builds.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!