Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cabal flags manual #484

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

tomsmeding
Copy link
Member

Description
This patch changes all cabal flags to manual in accelerate.cabal.

Motivation and context
This prevents Cabal from automatically assigning flags in the constraint solver. This currently cannot result in issues: if any build configuration is valid, the default one is valid too. However, using 'manual' flags makes this future-proof against changes within Accelerate, and also changes within Cabal: with 'manual' we select the semantically correct type of flag.

This should not adversely affect anything, especially since the flags are only meant for Accelerate developers and testers anyway.

How has this been tested?
Accelerate still builds.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

This prevents Cabal from automatically assigning flags in the constraint
solver. This currently cannot result in issues: if any build
configuration is valid, the default one is valid too. However, using
'manual' flags makes this future-proof against changes within
Accelerate, and also changes within Cabal: with 'manual' we select the
semantically correct type of flag.

This should not adversely affect anything, especially since the flags
are only meant for Accelerate developers and testers anyway.
@tmcdonell tmcdonell merged commit 5425788 into AccelerateHS:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants