Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that arrays in expressions are ArrayVars #457

Merged
merged 42 commits into from
Jun 5, 2020

Conversation

ivogabe
Copy link
Contributor

@ivogabe ivogabe commented May 25, 2020

Description

This should be reviewed and merged after #455!

This PR enforces that array computations nested in expressions are always an ArrayVar. Previously this was practically the case, as we assumed that it only contained variables. We enforce this by removing the acc type argument of PreOpenExp. This also means that the expressions don't have to be compiled from for instance PreOpenExp OpenAcc to PreOpenExp DelayedAcc.

Motivation and context

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

It accidentally consisted of zeros instead of -1
&& and || are now defined in terms of if-then-else
&&! and ||! are strict variants of them, which do not short circuit
tmcdonell added a commit to tmcdonell/accelerate that referenced this pull request Jun 5, 2020
@tmcdonell tmcdonell merged commit d2ddb2e into AccelerateHS:master Jun 5, 2020
@ivogabe ivogabe deleted the exp-acc-var branch June 6, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants