-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce that arrays in expressions are ArrayVars #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix true / false patterns
It accidentally consisted of zeros instead of -1
&& and || are now defined in terms of if-then-else &&! and ||! are strict variants of them, which do not short circuit
…nto refactor-expression-tuples
Previously defined in accelerate-llvm
This may duplicate work
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should be reviewed and merged after #455!
This PR enforces that array computations nested in expressions are always an ArrayVar. Previously this was practically the case, as we assumed that it only contained variables. We enforce this by removing the
acc
type argument of PreOpenExp. This also means that the expressions don't have to be compiled from for instancePreOpenExp OpenAcc
toPreOpenExp DelayedAcc
.Motivation and context
How has this been tested?
Types of changes
Checklist: