-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claim Account to use Eip-712 #1755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 72.30% 72.28% -0.02%
==========================================
Files 171 171
Lines 18730 18645 -85
==========================================
- Hits 13542 13477 -65
+ Misses 5188 5168 -20
Continue to review full report at Codecov.
|
/bench runtime acala module-evm-accounts |
Finished benchmark for branch: fer-evm-claim-eip712 Benchmark: Benchmark Runtime Acala Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/ ResultsCompiling acala-cli v2.1.3 (/app/git/Acala/node/cli) Caused by: --- stderr �[0m�[1m�[33mwarning�[0m�[0m�[1m: unused import: �[0m�[1m�[38;5;9merror[E0107]�[0m�[0m�[1m: this struct takes 7 generic arguments but 8 generic arguments were supplied�[0m �[0m�[1mSome errors have detailed explanations: E0107, E0432.�[0m |
/bench runtime acala module-evm-accounts |
Finished benchmark for branch: fer-evm-claim-eip712 Benchmark: Benchmark Runtime Acala Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/ ResultsPallet: "module_evm_accounts", Extrinsic: "claim_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
…hmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/
/bench runtime karura module-evm-accounts |
Finished benchmark for branch: fer-evm-claim-eip712 Benchmark: Benchmark Runtime Karura Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/ ResultsPallet: "module_evm_accounts", Extrinsic: "claim_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
/bench runtime mandala module-evm-accounts |
…hmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/
Finished benchmark for branch: fer-evm-claim-eip712 Benchmark: Benchmark Runtime Mandala Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/ ResultsPallet: "module_evm_accounts", Extrinsic: "claim_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
…hmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module-evm-accounts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create an issue in https://github.com/AcalaNetwork/bodhi.js/issues
* origin/master: (53 commits) add new audit report Use ExitReason::Revert instead of ExitReason::Error (#1772) Claim Account to use Eip-712 (#1755) Benchmark evm (#1674) support evm create rpc and allow H160 default (#1771) Update template files license header. (#1770) Fix collect_fee (#1766) handle nonce for eth tx (#1707) updated to the ORML's test coverage file (#1760) rm runtime upgrade (#1757) Happy new year 2022. (#1761) Excluded some files from test coverage (#1759) XCM: add deposit error handler for multi-currency adapter. (#1756) update stable asset (#1758) Fix test coverage for acala (#1590) Fix collect_fee (#1754) Update HEADER-GPL3 Update extrinsic-ordering-check-from-bin.yml (#1752) Update HEADER-GPL3 bump version (#1751) ...
closes #1579
I believe this signature would work with no collision problems (Obviously still need to update tests/benchmarks)