Update Dex Benchmaking #1588

ferrell-code · 2021-11-03T23:01:55Z

Fixes swap benchmarks, I can restore the weights files if we don't want to merge that right now

ferrell-code · 2021-11-03T23:04:53Z

/bench runtime module module_dex

ghost · 2021-11-03T23:04:55Z

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 127.2 0.531 0.4%
3 125.3 0.199 0.1%
4 145.8 0.314 0.2%

Quality and confidence:
param error
u 1.223

Model:
Time ~= 104.8
+ u 9.326
µs

Reads = 4 + (0 * u)
Writes = 3 + (0 * u)

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Dex LiquidityPool (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Tokens Accounts (r:2 w:2)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 100.1
+ u 15.19
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 130.5 0.36 0.2%
3 145.6 0.28 0.1%
4 160.9 0.678 0.4%

Quality and confidence:
param error
u 0.109

Model:
Time ~= 100
+ u 15.22
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

ferrell-code · 2021-11-04T00:18:18Z

/bench runtime karura module_dex

ghost · 2021-11-04T00:18:20Z

Finished benchmark for branch: fer-bench-audits

Benchmark: Benchmark Runtime Karura Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module module_dex --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Updating git repository `https://github.com/paritytech//cumulus`

warning: unused import: MultiCurrency
--> runtime/acala/src/benchmarking/../../../mandala/src/benchmarking/dex.rs:28:19
|
28 | use orml_traits::{MultiCurrency, MultiCurrencyExtended};
| ^^^^^^^^^^^^^

warning: unused imports: InitialShareExchangeRates, ProvisioningParameters
--> runtime/karura/src/benchmarking/../../../mandala/src/benchmarking/dex.rs:26:18
|
26 | use module_dex::{InitialShareExchangeRates, ProvisioningParameters, TradingPairStatus};
| ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default

warning: unused import: MultiCurrency
--> runtime/karura/src/benchmarking/../../../mandala/src/benchmarking/dex.rs:28:19
|
28 | use orml_traits::{MultiCurrency, MultiCurrencyExtended};
| ^^^^^^^^^^^^^

Compiling acala-rpc v2.0.0 (/app/git/Acala/rpc)
Compiling cumulus-client-service v0.1.0 (https://github.com/paritytech//cumulus?rev=935bac869a72baef17e46d2ae1abc8c0c650cef5#935bac86)
warning: unused imports: InitialShareExchangeRates, ProvisioningParameters
--> runtime/mandala/src/benchmarking/dex.rs:26:18
|
26 | use module_dex::{InitialShareExchangeRates, ProvisioningParameters, TradingPairStatus};
| ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default

warning: unused import: MultiCurrency
--> runtime/mandala/src/benchmarking/dex.rs:28:19
|
28 | use orml_traits::{MultiCurrency, MultiCurrencyExtended};
| ^^^^^^^^^^^^^

warning: 2 warnings emitted

Compiling acala-service v2.0.0 (/app/git/Acala/node/service)
warning: 2 warnings emitted

Compiling polkadot-cli v0.9.12 (https://github.com/paritytech//polkadot?rev=5feed981cf0fe671447eabaa9c0d235a8dd0003e#5feed981)
warning: 2 warnings emitted

Compiling acala v2.0.0 (/app/git/Acala/node)
Finished release [optimized] target(s) in 16m 41s
Running target/release/acala benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module module_dex '--extrinsic=*' --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/
error: Found argument 'module_dex' which wasn't expected, or isn't valid in this context

USAGE:
acala benchmark --chain <CHAIN_SPEC> --extrinsic --pallet --repeat --steps

For more information try --help

ghost · 2021-11-04T00:36:52Z

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 135.1 0.282 0.2%
3 135.7 0.377 0.2%
4 156.4 0.392 0.2%

Quality and confidence:
param error
u 1.103

Model:
Time ~= 110.4
+ u 10.66
µs

Reads = 4 + (0 * u)
Writes = 3 + (0 * u)

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Dex LiquidityPool (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Tokens Accounts (r:2 w:2)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 106.9
+ u 16.18
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 139.4 0.489 0.3%
3 155.7 0.544 0.3%
4 171.6 0.317 0.1%

Quality and confidence:
param error
u 0.108

Model:
Time ~= 107.3
+ u 16.1
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

ferrell-code · 2021-11-04T03:54:14Z

/bench runtime karura module_dex

ghost · 2021-11-04T03:54:15Z

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 131 0.352 0.2%
3 146.3 0.426 0.2%
4 161.7 0.659 0.4%

Quality and confidence:
param error
u 0.115

Model:
Time ~= 100.3
+ u 15.34
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Dex LiquidityPool (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Tokens Accounts (r:2 w:2)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 101.5
+ u 14.91
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 131.6 0.981 0.7%
3 146.2 0.58 0.3%
4 161.3 0.397 0.2%

Quality and confidence:
param error
u 0.164

Model:
Time ~= 101.8
+ u 14.84
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

ferrell-code · 2021-11-04T04:24:18Z

fn swap_with_exact_supply(u: u32, ) -> Weight {
	(71_776_000 as Weight)
		// Standard Error: 152_000
		.saturating_add((10_256_000 as Weight).saturating_mul(u as Weight))
		.saturating_add(T::DbWeight::get().reads(1 as Weight))
		.saturating_add(T::DbWeight::get().reads((2 as Weight).saturating_mul(u as Weight)))
		.saturating_add(T::DbWeight::get().writes(2 as Weight))
		.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(u as Weight)))
}
fn swap_with_exact_target(u: u32, ) -> Weight {
	(72_164_000 as Weight)
		// Standard Error: 252_000
		.saturating_add((9_648_000 as Weight).saturating_mul(u as Weight))
		.saturating_add(T::DbWeight::get().reads(1 as Weight))
		.saturating_add(T::DbWeight::get().reads((2 as Weight).saturating_mul(u as Weight)))
		.saturating_add(T::DbWeight::get().writes(2 as Weight))
		.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(u as Weight)))
}

ferrell-code · 2021-11-04T04:26:12Z

Locally I get that output (which I believe to be correct), but the benchbot doesn't generate the same reads and write scheme, obviously the numbers are different but shouldn't the reads and writes be identical across machines?

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

bench-bot also gets the same results it appears but isn't updating weights file?

ferrell-code · 2021-11-04T05:05:32Z

/bench runtime karura *

ghost · 2021-11-04T05:05:34Z

Finished benchmark for branch: fer-bench-audits

Benchmark: Benchmark Runtime Karura Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=* --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Pallet: "module_nft", Extrinsic: "create_class", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: OrmlNFT NextClassId (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Balances Reserves (r:1 w:1)
Storage: Proxy Proxies (r:1 w:1)
Storage: OrmlNFT Classes (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 153.6
µs

-- Extrinsic Time --

Model:
Time ~= 222.5
µs

Reads = 7
Writes = 7

Pallet: "module_nft", Extrinsic: "burn", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: OrmlNFT Classes (r:1 w:1)
Storage: OrmlNFT Tokens (r:1 w:1)
Storage: Balances Reserves (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: OrmlNFT TokensByOwner (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 168
µs

Reads = 4
Writes = 5

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 168
µs

Reads = 4
Writes = 5

Pallet: "module_nft", Extrinsic: "burn_with_remark", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: OrmlNFT Classes (r:1 w:1)
Storage: OrmlNFT Tokens (r:1 w:1)
Storage: Balances Reserves (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: OrmlNFT TokensByOwner (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 166.6
+ b 0.002
µs

Reads = 4 + (0 * b)
Writes = 5 + (0 * b)

Min Squares Analysis

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 128.4 0.353 0.2%
3 143.6 0.474 0.3%
4 158.7 0.474 0.2%

Reads = 11
Writes = 8

Pallet: "module_cdp_engine", Extrinsic: "on_initialize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: CdpEngine LastAccumulationSecs (r:1 w:1)
Storage: EmergencyShutdown IsShutdown (r:1 w:0)
Storage: CdpEngine CollateralParams (r:2 w:0)
Storage: CdpEngine GlobalInterestRatePerSec (r:1 w:0)
Storage: Loans TotalPositions (r:2 w:0)
Storage: Timestamp Now (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 31.48
+ c 4.065
µs

Reads = 7 + (0 * c)
Writes = 2 + (0 * c)

Min Squares Analysis

Reads = 11 + (2 * c)
Writes = 1 + (4 * c)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
c mean µs sigma µs %
0 92.25 0.284 0.3%
1 116.3 1.616 1.3%

Quality and confidence:
param error
c 0.547

Model:
Time ~= 92.25
+ c 24.07
µs

Reads = 11 + (2 * c)
Writes = 1 + (4 * c)

Pallet: "module_emergency_shutdown", Extrinsic: "open_collateral_refund", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: EmergencyShutdown IsShutdown (r:1 w:0)
Storage: AuctionManager TotalCollateralInAuction (r:2 w:0)
Storage: Loans TotalPositions (r:2 w:0)
Storage: EmergencyShutdown CanRefund (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 37.87
µs

Reads = 5
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 37.87
µs

Reads = 5
Writes = 1

Pallet: "module_emergency_shutdown", Extrinsic: "refund_collaterals", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: EmergencyShutdown CanRefund (r:1 w:0)
Storage: Tokens TotalIssuance (r:1 w:1)
Storage: Tokens Accounts (r:3 w:1)
Storage: EvmAccounts EvmAddresses (r:1 w:0)
Storage: EVM Accounts (r:1 w:0)
Storage: EvmAccounts Accounts (r:0 w:1)
Storage: System Account (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 97.8
+ c 56.35
µs

Reads = 7 + (2 * c)
Writes = 3 + (2 * c)

Min Squares Analysis

Reads = 1 + (0 * c)
Writes = 0 + (2 * c)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
c mean µs sigma µs %
0 27.06 0.323 1.1%
1 55.82 0.225 0.4%

Quality and confidence:
param error
c 0.131

Model:
Time ~= 27.06
+ c 28.76
µs

Reads = 1 + (0 * c)
Writes = 0 + (2 * c)

Pallet: "module_honzon", Extrinsic: "adjust_loan", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: EmergencyShutdown IsShutdown (r:1 w:0)
Storage: Loans Positions (r:1 w:1)
Storage: Rewards SharesAndWithdrawnRewards (r:1 w:1)
Storage: Rewards PoolInfos (r:1 w:1)
Storage: Loans TotalPositions (r:1 w:1)
Storage: Tokens Accounts (r:3 w:3)
Storage: System Account (r:1 w:1)
Storage: CdpEngine CollateralParams (r:1 w:0)
Storage: CdpEngine DebitExchangeRate (r:1 w:0)
Storage: Tokens TotalIssuance (r:1 w:1)
Storage: Prices LockedPrice (r:2 w:0)
Storage: AcalaOracle IsUpdated (r:1 w:1)
Storage: OperatorMembershipAcala Members (r:1 w:0)
Storage: AcalaOracle RawValues (r:6 w:0)
Storage: AcalaOracle Values (r:1 w:1)
Storage: Timestamp Now (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 245.1
µs

Reads = 24
Writes = 11

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 245.1
µs

Reads = 24
Writes = 11

Pallet: "module_honzon", Extrinsic: "transfer_loan_from", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: EmergencyShutdown IsShutdown (r:1 w:0)
Storage: Honzon Authorization (r:1 w:0)
Storage: Loans Positions (r:2 w:2)
Storage: CdpEngine DebitExchangeRate (r:1 w:0)
Storage: Prices LockedPrice (r:2 w:0)
Storage: AcalaOracle IsUpdated (r:1 w:0)
Storage: AcalaOracle Values (r:1 w:0)
Storage: CdpEngine CollateralParams (r:1 w:0)
Storage: Rewards SharesAndWithdrawnRewards (r:2 w:2)
Storage: Rewards PoolInfos (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Loans TotalPositions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 141.9
µs

-- Extrinsic Time --

Model:
Time ~= 61.67
µs

Reads = 6
Writes = 7

Pallet: "module_cdp_treasury", Extrinsic: "set_expected_collateral_auction_size", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: CdpTreasury ExpectedCollateralAuctionSize (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 20.15
µs

Reads = 0
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 20.15
µs

Reads = 0
Writes = 1

Pallet: "module_cdp_treasury", Extrinsic: "extract_surplus_to_treasury", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Tokens Accounts (r:2 w:2)
Storage: System Account (r:2 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 68.03
µs

-- Extrinsic Time --

Model:
Time ~= 16.52
µs

Reads = 0
Writes = 1

Pallet: "module_collator_selection", Extrinsic: "set_candidacy_bond", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: CollatorSelection CandidacyBond (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 16.93
µs

-- Extrinsic Time --

Model:
Time ~= 60.01
µs

Reads = 3
Writes = 2

Pallet: "module_collator_selection", Extrinsic: "note_author", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: System Account (r:2 w:2)
Storage: CollatorSelection SessionPoints (r:1 w:0)
Storage: System BlockWeight (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 61.54
µs

Reads = 4
Writes = 3

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 61.54
µs

Reads = 4
Writes = 3

Pallet: "module_collator_selection", Extrinsic: "new_session", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: CollatorSelection Candidates (r:1 w:0)
Storage: CollatorSelection Invulnerables (r:1 w:0)
Storage: System BlockWeight (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 32.58
µs

Reads = 2 + (5 * c)
Writes = 0 + (0 * c)

Min Squares Analysis

Reads = 1 + (2 * c)
Writes = 1 + (2 * c)

Min Squares Analysis

Reads = 3 + (0 * i)
Writes = 2 + (0 * i)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
i mean µs sigma µs %
1 48.95 0.232 0.4%
2 49.74 0.32 0.6%
3 48.97 0.166 0.3%
4 49.41 0.229 0.4%
5 49.31 0.176 0.3%
6 49.76 0.291 0.5%
7 49.79 0.308 0.6%
8 50.02 0.437 0.8%
9 49.71 0.152 0.3%
10 50.03 0.341 0.6%
11 49.97 0.277 0.5%
12 50.07 0.273 0.5%
13 50.31 0.326 0.6%
14 49.93 0.149 0.2%
15 70.06 9.461 13.5%
16 49.79 0.201 0.4%
17 50.02 0.252 0.5%
18 50.36 0.288 0.5%
19 50.34 0.329 0.6%
20 50.55 0.256 0.5%
21 50.35 0.206 0.4%
22 50.52 0.181 0.3%
23 50.33 0.388 0.7%
24 50.3 0.222 0.4%
25 50.22 0.188 0.3%
26 50.34 0.24 0.4%
27 50.3 0.231 0.4%
28 50.44 0.296 0.5%
29 50.37 0.328 0.6%
30 50.68 0.211 0.4%
31 50.39 0.213 0.4%
32 50.53 0.353 0.6%
33 50.48 0.199 0.3%
34 50.6 0.255 0.5%
35 50.05 0.276 0.5%
36 50.44 0.197 0.3%
37 50.66 0.335 0.6%
38 50.72 0.683 1.3%
39 50.39 0.259 0.5%
40 50.08 0.245 0.4%
41 50.38 0.276 0.5%
42 50.14 0.252 0.5%
43 50.06 0.323 0.6%
44 50.62 0.345 0.6%
45 50.46 0.235 0.4%
46 50.04 0.214 0.4%
47 50.55 0.189 0.3%
48 50.57 0.223 0.4%
49 50.68 0.284 0.5%
50 50.51 0.167 0.3%
51 50.67 0.228 0.4%
52 50.86 0.471 0.9%
53 50.53 0.287 0.5%
54 50.36 0.244 0.4%
55 50.77 0.286 0.5%
56 51.24 0.345 0.6%
57 50.46 0.289 0.5%
58 50.94 0.319 0.6%
59 50.44 0.154 0.3%
60 50.24 0.26 0.5%
61 50.29 0.264 0.5%
62 50.86 0.264 0.5%
63 50.64 0.223 0.4%
64 50.15 0.294 0.5%
65 54.29 6.102 11.2%
66 50.67 0.188 0.3%
67 50.83 0.44 0.8%
68 50.65 0.213 0.4%
69 50.91 0.393 0.7%
70 50.79 0.238 0.4%
71 50.51 0.235 0.4%
72 50.39 0.254 0.5%
73 50.82 0.367 0.7%
74 50.81 0.176 0.3%
75 50.7 0.208 0.4%
76 50.59 0.316 0.6%
77 51.1 0.287 0.5%
78 50.81 0.543 1.0%
79 50.6 0.254 0.5%
80 51.03 0.328 0.6%
81 50.87 0.376 0.7%
82 50.59 0.241 0.4%
83 50.66 0.281 0.5%
84 50.67 0.252 0.4%
85 50.52 0.282 0.5%
86 50.67 0.213 0.4%
87 51.04 0.4 0.7%
88 50.73 0.29 0.5%
89 50.91 0.303 0.5%
90 50.83 0.242 0.4%
91 50.74 0.237 0.4%
92 51.27 0.816 1.5%
93 51.02 0.404 0.7%
94 51.03 0.428 0.8%
95 50.68 0.223 0.4%
96 51.61 0.241 0.4%
97 50.69 0.338 0.6%
98 50.49 0.237 0.4%
99 50.51 0.294 0.5%
100 50.29 0.15 0.2%

Reads = 8
Writes = 9

Pallet: "orml_auction", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Auction AuctionEndTime (r:2 w:1)
Storage: Auction Auctions (r:1 w:1)
Storage: AuctionManager CollateralAuctions (r:1 w:1)
Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Tokens Accounts (r:2 w:2)
Storage: System Account (r:3 w:3)
Storage: AuctionManager TotalCollateralInAuction (r:1 w:1)
Storage: AuctionManager TotalTargetInAuction (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 42.3
+ c 81.82
µs

Reads = 9 + (3 * c)
Writes = 7 + (3 * c)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
c mean µs sigma µs %
1 143.9 0.507 0.3%
2 227.2 1.222 0.5%
3 303.7 0.709 0.2%
4 385.4 1.33 0.3%
5 467.8 1.867 0.3%
6 548.6 2.226 0.4%
7 637.2 4.088 0.6%
8 708.8 2.005 0.2%
9 781.5 3.626 0.4%
10 871.7 2.842 0.3%
11 943.2 2.783 0.2%
12 1019 5.366 0.5%
13 1105 4.543 0.4%
14 1190 6.888 0.5%
15 1271 6.879 0.5%
16 1347 5.709 0.4%
17 1446 11.81 0.8%
18 1511 5.526 0.3%
19 1680 152.6 9.0%
20 1666 6.181 0.3%
21 1755 5.753 0.3%
22 1838 5.166 0.2%
23 1905 6.005 0.3%
24 1992 3.389 0.1%
25 2084 7.439 0.3%
26 2166 3.757 0.1%
27 2245 7.466 0.3%
28 2326 6.536 0.2%
29 2402 4.299 0.1%
30 2494 8.124 0.3%
31 2582 7.196 0.2%
32 2666 8.684 0.3%
33 2734 5.5 0.2%
34 2819 10.06 0.3%
35 2893 7.509 0.2%
36 3104 39.74 1.2%
37 3061 10.09 0.3%
38 3142 7.513 0.2%
39 3202 4.955 0.1%
40 3290 3.64 0.1%
41 3393 13.57 0.3%
42 3454 4.893 0.1%
43 3590 27.12 0.7%
44 3616 7.772 0.2%
45 3686 3.615 0.0%
46 3783 3.898 0.1%
47 3869 4.861 0.1%
48 3962 5.671 0.1%
49 4042 7.478 0.1%
50 4117 7.23 0.1%
51 4198 6.989 0.1%
52 4289 6.383 0.1%
53 4392 56.89 1.2%
54 4434 4.947 0.1%
55 4562 8.982 0.1%
56 4634 8.843 0.1%
57 4685 5.412 0.1%
58 4756 7.473 0.1%
59 4839 8.388 0.1%
60 4918 11.91 0.2%
61 5012 7.779 0.1%
62 5075 6.087 0.1%
63 5193 11.12 0.2%
64 5255 5.006 0.0%
65 5337 8.712 0.1%
66 5409 13.15 0.2%
67 5539 28.6 0.5%
68 5644 22.81 0.4%
69 5693 4.918 0.0%
70 5750 11.39 0.1%
71 5830 14.52 0.2%
72 5924 9.371 0.1%
73 6016 5.11 0.0%
74 6073 8.132 0.1%
75 6202 14.47 0.2%
76 6256 13.78 0.2%
77 6357 7.381 0.1%
78 6422 7.75 0.1%
79 6490 11.41 0.1%
80 6579 9.331 0.1%
81 6691 9.157 0.1%
82 6798 15.97 0.2%
83 6820 8.213 0.1%
84 6892 21.3 0.3%
85 7012 9.73 0.1%
86 7112 32.96 0.4%
87 7183 15.19 0.2%
88 7254 8.383 0.1%
89 7351 10.96 0.1%
90 7450 17.15 0.2%
91 7514 8.668 0.1%
92 7592 18.15 0.2%
93 7670 12.99 0.1%
94 7774 14.58 0.1%
95 7832 15.77 0.2%
96 7907 10.23 0.1%
97 8004 15.46 0.1%
98 8124 13.59 0.1%
99 8151 9.258 0.1%
100 8230 8.812 0.1%

Quality and confidence:
param error
c 0.034

Model:
Time ~= 40.18
+ c 81.9
µs

Reads = 9 + (3 * c)
Writes = 7 + (3 * c)

-- Extrinsic Time --

Model:
Time ~= 5.787
µs

Reads = 0
Writes = 1

ferrell-code · 2021-11-04T20:55:55Z

/bench runtime karura module_dex

ghost · 2021-11-04T20:55:57Z

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 132.3 0.44 0.3%
3 147.8 0.351 0.2%
4 162.7 0.823 0.5%

Quality and confidence:
param error
u 0.138

Model:
Time ~= 102
+ u 15.19
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Dex LiquidityPool (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Tokens Accounts (r:2 w:2)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 102.7
+ u 14.89
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 132.3 0.439 0.3%
3 147.4 0.369 0.2%
4 162.2 0.677 0.4%

Quality and confidence:
param error
u 0.119

Model:
Time ~= 102.4
+ u 14.95
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

…hmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_dex --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

into fer-bench-audits

ferrell-code · 2021-11-05T02:14:13Z

/bench runtime karura module_dex

ghost · 2021-11-05T02:14:14Z

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 127.9 0.434 0.3%
3 146.3 0.503 0.3%
4 163.4 0.299 0.1%

Quality and confidence:
param error
u 0.118

Model:
Time ~= 92.6
+ u 17.77
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Dex LiquidityPool (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Tokens Accounts (r:2 w:2)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 93.25
+ u 17.88
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 128.7 0.458 0.3%
3 156.5 25.77 16.4%
4 165.1 2.428 1.4%

Quality and confidence:
param error
u 3.617

Model:
Time ~= 95.44
+ u 18.23
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

…hmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_dex --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

ferrell-code · 2021-11-05T02:45:42Z

/bench runtime mandala module_dex

ghost · 2021-11-05T02:45:43Z

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 130.3 0.659 0.5%
3 147 0.271 0.1%
4 163.1 0.612 0.3%

Quality and confidence:
param error
u 0.13

Model:
Time ~= 97.6
+ u 16.42
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Dex TradingPairStatuses (r:1 w:0)
Storage: Dex LiquidityPool (r:1 w:1)
Storage: System Account (r:1 w:1)
Storage: Tokens Accounts (r:2 w:2)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 99.25
+ u 15.93
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
u mean µs sigma µs %
2 130.4 0.351 0.2%
3 150.8 5.13 3.4%
4 162.4 0.337 0.2%

Quality and confidence:
param error
u 0.837

Model:
Time ~= 99.8
+ u 16.03
µs

Reads = 1 + (2 * u)
Writes = 2 + (1 * u)

…hmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_dex --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

xlc

the weight changes looks reasonable

ermalkaleci

LGTM

* origin/master: Feature/homa lite periodic update (#1538) Fix/repatriate emit event (#1586) Update Dex Benchmaking (#1588) clear unused modules dependencies and rpc for runtimes (#1593) Idle schedule evm task (#1583) update acala genesis update devcontainer Dockerfile

benches

ac4d347

ferrell-code marked this pull request as draft November 3, 2021 23:02

compile

74d9d8b

update

c56c8fc

Acala Benchmarking Bot and others added 4 commits November 4, 2021 20:56

Merge remote-tracking branch 'origin/master' into fer-bench-audits

7f8f430

update benchmark

e3a4b4c

Merge branch 'fer-bench-audits' of https://github.com/AcalaNetwork/Acala

135e256

into fer-bench-audits

Merge remote-tracking branch 'origin/master' into fer-bench-audits

b7d3d8b

ferrell-code changed the title ~~Do Not Merge: Testing Benches~~ Update Dex Benchmaking Nov 5, 2021

ferrell-code marked this pull request as ready for review November 5, 2021 02:37

ferrell-code mentioned this pull request Nov 5, 2021

Review weight & benchmarks. #1555

Open

xlc requested a review from ermalkaleci November 5, 2021 04:17

xlc approved these changes Nov 5, 2021

View reviewed changes

ermalkaleci approved these changes Nov 5, 2021

View reviewed changes

xlc merged commit 9643104 into master Nov 7, 2021

xlc deleted the fer-bench-audits branch November 7, 2021 22:01

Update Dex Benchmaking #1588

Update Dex Benchmaking #1588

Conversation

ferrell-code commented Nov 3, 2021 • edited Loading

ferrell-code commented Nov 3, 2021

ghost commented Nov 3, 2021 • edited by ghost Loading

Pallet: "module_dex", Extrinsic: "enable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "disable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "list_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "update_provisioning_parameters", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "end_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "add_provision", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "claim_dex_share", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "add_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "add_liquidity_and_stake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "remove_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "remove_liquidity_by_unstake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "swap_with_exact_supply", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

ferrell-code commented Nov 4, 2021 • edited Loading

ghost commented Nov 4, 2021 • edited by ghost Loading

ghost commented Nov 4, 2021 • edited by ghost Loading

Pallet: "module_dex", Extrinsic: "enable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "disable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "list_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "update_provisioning_parameters", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "end_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "add_provision", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "claim_dex_share", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "add_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "add_liquidity_and_stake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "remove_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_dex", Extrinsic: "remove_liquidity_by_unstake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

ferrell-code commented Nov 3, 2021 •

edited

Loading

ghost commented Nov 3, 2021 •

edited by ghost

Loading

Pallet: "module_dex", Extrinsic: "enable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "disable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "list_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "update_provisioning_parameters", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "end_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_provision", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "claim_dex_share", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_liquidity_and_stake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "remove_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "remove_liquidity_by_unstake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "swap_with_exact_supply", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ferrell-code commented Nov 4, 2021 •

edited

Loading

ghost commented Nov 4, 2021 •

edited by ghost

Loading

ghost commented Nov 4, 2021 •

edited by ghost

Loading

Pallet: "module_dex", Extrinsic: "enable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "disable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "list_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "update_provisioning_parameters", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "end_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_provision", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "claim_dex_share", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_liquidity_and_stake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "remove_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "remove_liquidity_by_unstake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "swap_with_exact_supply", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Nov 4, 2021 •

edited by ghost

Loading

Pallet: "module_dex", Extrinsic: "enable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "disable_trading_pair", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "list_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "update_provisioning_parameters", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "end_provisioning", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_provision", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "claim_dex_share", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "add_liquidity_and_stake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "remove_liquidity", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "remove_liquidity_by_unstake", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "swap_with_exact_supply", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_dex", Extrinsic: "swap_with_exact_target", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ferrell-code commented Nov 4, 2021 •

edited

Loading

ghost commented Nov 4, 2021 •

edited by ghost

Loading

Pallet: "module_nft", Extrinsic: "create_class", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_nft", Extrinsic: "mint", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_nft", Extrinsic: "transfer", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_nft", Extrinsic: "burn", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_nft", Extrinsic: "burn_with_remark", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info