-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error caused by weakly referenced package not specifying version … #1712
Fix error caused by weakly referenced package not specifying version … #1712
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
+ Coverage 58.27% 58.29% +0.01%
==========================================
Files 126 126
Lines 17157 17159 +2
Branches 3504 3505 +1
==========================================
+ Hits 9998 10002 +4
+ Misses 6494 6493 -1
+ Partials 665 664 -1 ☔ View full report in Codecov by Sentry. |
@loonghao Thanks for creating this PR. Do you think you could add a test for these lines: https://github.com/AcademySoftwareFoundation/rez/pull/1712/files#diff-1ad6984e6ce49221a86620d55092bacae0b32b2d6c9401295c655c9d3e72a1a0R443-R446? |
db85913
to
86553da
Compare
@JeanChristopheMorinPerso |
027c47f
to
e3c07bd
Compare
…range Signed-off-by: loonghao <hal.long@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @loonghao and @isohedronpipeline!
8decb45
into
AcademySoftwareFoundation:main
…range (AcademySoftwareFoundation#1712) Signed-off-by: loonghao <hal.long@outlook.com>
This PR is try to fix #1711