Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final group capstone - Book an Appointment #19

Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
112 commits
Select commit Hold shift + click to select a range
b23a2bf
Complete initial setup
bobb-Rob Oct 26, 2022
cad4403
Add react bootstrap
bobb-Rob Oct 26, 2022
fb0d09d
Add default text to App
bobb-Rob Oct 26, 2022
9b51085
Merge pull request #9 from Abdo9826/set-up
bobb-Rob Oct 27, 2022
7352c68
Complete splash page with sign in and sign uop button
bobb-Rob Oct 27, 2022
74ad1c2
Adjust splash page icon wrap
bobb-Rob Oct 27, 2022
fe33277
fix linters
Abdo9826 Oct 27, 2022
8e2aa6e
Splash page linked to sign in and and sign up form
bobb-Rob Oct 27, 2022
351b94f
Add sign in page
bobb-Rob Oct 27, 2022
b934aa3
Implement Sign-up and login
bobb-Rob Oct 27, 2022
5e26fbc
Complete sign in, sign up, and default page after sign in
bobb-Rob Oct 28, 2022
b17ceb4
Fix eslinter issues
bobb-Rob Oct 28, 2022
d975c5c
Fix css linters
bobb-Rob Oct 28, 2022
a7d1a0d
Merge pull request #10 from Abdo9826/sign-in/sign-up
shahnawaza75 Oct 28, 2022
1b11e67
Add cars fprm compenets with hhtml
Abdo9826 Oct 31, 2022
88c6569
Add styles to splash component
Abdo9826 Oct 31, 2022
c47f209
Add styles for form
Abdo9826 Oct 31, 2022
4458b34
Remove error condition in jwt token function
bobb-Rob Nov 1, 2022
e12a921
Initial carcard
shahnawaza75 Nov 1, 2022
44ad571
Add car CArd component
shahnawaza75 Nov 1, 2022
5c2fd66
Update Cars container component
shahnawaza75 Nov 1, 2022
c97e4fd
Add carSlice.js redux reducers and actions
shahnawaza75 Nov 1, 2022
d34b2ab
Update CarSlice extra reducer
shahnawaza75 Nov 1, 2022
469d2c3
Add carsPage compnent
shahnawaza75 Nov 1, 2022
b337384
Update the cars component with feature_image key
shahnawaza75 Nov 1, 2022
2a7496a
Add carCard compnent
shahnawaza75 Nov 1, 2022
10e6086
Add mobile version for cars form
Abdo9826 Nov 1, 2022
f705f72
Add all styles for add cars form
Abdo9826 Nov 1, 2022
2799570
fix linters
Abdo9826 Nov 1, 2022
fe245bd
Install react-hook-form
shahnawaza75 Nov 1, 2022
8aae67c
Update decs to specification on cars model
shahnawaza75 Nov 1, 2022
78042bb
Add Signup success page
shahnawaza75 Nov 1, 2022
b3c62f7
Change long folder name from signIn... to Auth
shahnawaza75 Nov 1, 2022
cdd4cc3
Update description to specification on cars model
shahnawaza75 Nov 1, 2022
5343021
Implement form validation on user sign in
shahnawaza75 Nov 1, 2022
a509ef4
Merge pull request #11 from Abdo9826/addcars
bobb-Rob Nov 1, 2022
fac2005
Add styles to cars component
shahnawaza75 Nov 2, 2022
d540de3
implement CarsDetails component using nesting routes
shahnawaza75 Nov 2, 2022
816a6b4
Create main and nav pages
ksigei Nov 2, 2022
addfc08
Complete car list and car details page
shahnawaza75 Nov 2, 2022
fe906a8
Fix stylelint
shahnawaza75 Nov 2, 2022
6f8d159
Solve linter errors
ksigei Nov 2, 2022
4aefb86
Solve css file conflicts
ksigei Nov 2, 2022
c0c480b
Solve css file conflicts
ksigei Nov 2, 2022
bc9ce43
Solve css file conflicts
ksigei Nov 2, 2022
6d94990
Merge pull request #12 from Abdo9826/navbar
Abdo9826 Nov 2, 2022
2d6f2bb
Merge branch 'dev' into car-component
bobb-Rob Nov 2, 2022
f5860f8
Update Main conponent
bobb-Rob Nov 2, 2022
f1c7917
Fix eslint issues
bobb-Rob Nov 2, 2022
d8f47f7
Fix eslint issues
bobb-Rob Nov 2, 2022
6b63581
FIx conflict with Navbar
bobb-Rob Nov 2, 2022
f23c87d
Fix Navbar issues
bobb-Rob Nov 2, 2022
b7c0b98
Add Car form issue fixed
bobb-Rob Nov 2, 2022
c44c7f0
Merge pull request #13 from Abdo9826/car-component
Abdo9826 Nov 2, 2022
ff6e9f4
Add validations to cars form
Abdo9826 Nov 2, 2022
0b5be4f
create redux and add function for form
Abdo9826 Nov 2, 2022
48a330f
add delete components
Abdo9826 Nov 2, 2022
7d3edc3
Install react-slick for image carousel
bobb-Rob Nov 2, 2022
9c989f1
fix lnters
Abdo9826 Nov 2, 2022
fbd6459
Add some styling
Abdo9826 Nov 2, 2022
8edba55
Create reservation list
ksigei Nov 3, 2022
978e97f
add redux for delete component
Abdo9826 Nov 3, 2022
9cdc125
Add specifications to form with validation
Abdo9826 Nov 3, 2022
9a044b1
Fetched reservations
ksigei Nov 3, 2022
378d6e1
show database error to user as validation
bobb-Rob Nov 3, 2022
2f8c4af
Add delete function button
Abdo9826 Nov 3, 2022
fee861c
ADd css style to add reversation form
bobb-Rob Nov 3, 2022
5f718b6
modify delete function
Abdo9826 Nov 3, 2022
e48077f
Handle reservation failed error
bobb-Rob Nov 3, 2022
bc29d79
Reservation list
ksigei Nov 3, 2022
afa1707
Merge pull request #14 from Abdo9826/reservation-list
Abdo9826 Nov 3, 2022
3e3f9c0
Add some styles
Abdo9826 Nov 3, 2022
79a71dc
finish styling for splash ans login and logout
Abdo9826 Nov 3, 2022
9077411
fix bug
Abdo9826 Nov 4, 2022
1d7f3ea
Reservation list image
ksigei Nov 4, 2022
3d19bf7
fix bug
Abdo9826 Nov 4, 2022
d920ace
fib bugs
Abdo9826 Nov 4, 2022
975a0e4
Finish add reservation feature
bobb-Rob Nov 4, 2022
1c5536e
solve conflicts
Abdo9826 Nov 4, 2022
8c3b5c4
FIx linters
bobb-Rob Nov 4, 2022
11c8ad0
Fixed all linter issues
bobb-Rob Nov 4, 2022
2296969
Merge pull request #15 from Abdo9826/reserve-form
Abdo9826 Nov 4, 2022
918ab4e
solve conflicts amd linters errors
Abdo9826 Nov 4, 2022
95cfacc
Merge pull request #16 from Abdo9826/form
Abdo9826 Nov 4, 2022
a7d570a
Fixed reserve conflict
bobb-Rob Nov 4, 2022
618aa78
Merge pull request #17 from Abdo9826/reserve-form
ksigei Nov 4, 2022
23c0aef
Updated routing to fix routing issues
bobb-Rob Nov 4, 2022
4995fa1
fix bugs
bobb-Rob Nov 4, 2022
eff5ce8
Fix all issues
bobb-Rob Nov 4, 2022
a6a223f
Update reservation name to js insted of jsx
bobb-Rob Nov 4, 2022
ddd97e7
Merge pull request #18 from Abdo9826/hot-fix
bobb-Rob Nov 4, 2022
c19ad5b
Update README.md
Abdo9826 Nov 5, 2022
f9aa151
Update README.md
Abdo9826 Nov 5, 2022
3ebc804
Add tests
Abdo9826 Nov 5, 2022
c2f12be
fix linters
Abdo9826 Nov 5, 2022
bf58a09
fix linters
Abdo9826 Nov 5, 2022
225bd4e
Merge pull request #20 from Abdo9826/test
ksigei Nov 5, 2022
13dd2b6
Update README.MD
ksigei Nov 5, 2022
4ac59a2
Acknowledge the design owner
ksigei Nov 5, 2022
aed23de
Screenshots
ksigei Nov 5, 2022
e1fed4c
Screenshots
ksigei Nov 5, 2022
82963b6
Screenshots
ksigei Nov 5, 2022
813cc60
Update README.MD
ksigei Nov 5, 2022
987a2f6
Merge pull request #21 from Abdo9826/README
ksigei Nov 5, 2022
4ec7a10
Fix delete issue
bobb-Rob Nov 5, 2022
dd38f0e
Fix reservation delete
bobb-Rob Nov 5, 2022
21e9b03
Fix linters
bobb-Rob Nov 5, 2022
3fc346d
Merge pull request #23 from Abdo9826/hot-fix
Abdo9826 Nov 5, 2022
6f4d525
Update README
ksigei Nov 5, 2022
27f32ff
fix bugs
Abdo9826 Nov 5, 2022
b835e5f
Merge branch 'dev' of github.com:Abdo9826/cars-bnb-frontend into dev
Abdo9826 Nov 5, 2022
b15be6e
Update README.md
Abdo9826 Nov 5, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"presets": [
"@babel/preset-react"
],
"plugins": ["@babel/plugin-syntax-jsx"]
}
27 changes: 27 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"env": {
"browser": true,
"es6": true,
"jest": true
},
"parser": "@babel/eslint-parser",
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": 2018,
"sourceType": "module"
},
"extends": ["airbnb", "plugin:react/recommended", "plugin:react-hooks/recommended"],
"plugins": ["react"],
"rules": {
"react/jsx-filename-extension": ["warn", { "extensions": [".js", ".jsx"] }],
"react/react-in-jsx-scope": "off",
"import/no-unresolved": "off",
"no-shadow": "off"
},
"ignorePatterns": [
"dist/",
"build/"
]
}
45 changes: 45 additions & 0 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Linters

on: pull_request

env:
FORCE_COLOR: 1

jobs:
eslint:
name: ESLint
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: "12.x"
- name: Setup ESLint
run: |
npm install --save-dev eslint@7.x eslint-config-airbnb@18.x eslint-plugin-import@2.x eslint-plugin-jsx-a11y@6.x eslint-plugin-react@7.x eslint-plugin-react-hooks@4.x @babel/eslint-parser@7.x @babel/core@7.x @babel/plugin-syntax-jsx@7.x @babel/preset-env@7.x @babel/preset-react@7.x
[ -f .eslintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/react-redux/.eslintrc.json
[ -f .babelrc ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/react-redux/.babelrc
- name: ESLint Report
run: npx eslint .
stylelint:
name: Stylelint
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: "12.x"
- name: Setup Stylelint
run: |
npm install --save-dev stylelint@13.x stylelint-scss@3.x stylelint-config-standard@21.x stylelint-csstree-validator@1.x
[ -f .stylelintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/react-redux/.stylelintrc.json
- name: Stylelint Report
run: npx stylelint "**/*.{css,scss}"
nodechecker:
name: node_modules checker
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- name: Check node_modules existence
run: |
if [ -d "node_modules/" ]; then echo -e "\e[1;31mThe node_modules/ folder was pushed to the repo. Please remove it from the GitHub repository and try again."; echo -e "\e[1;32mYou can set up a .gitignore file with this folder included on it to prevent this from happening in the future." && exit 1; fi
23 changes: 23 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*
20 changes: 20 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"extends": ["stylelint-config-standard"],
"plugins": ["stylelint-scss", "stylelint-csstree-validator"],
"rules": {
"at-rule-no-unknown": [
true,
{
"ignoreAtRules": ["tailwind", "apply", "variants", "responsive", "screen"]
}
],
"scss/at-rule-no-unknown": [
true,
{
"ignoreAtRules": ["tailwind", "apply", "variants", "responsive", "screen"]
}
],
"csstree/validator": true
},
"ignoreFiles": ["build/**", "dist/**", "**/reset*.css", "**/bootstrap*.css", "**/*.js", "**/*.jsx"]
}
125 changes: 124 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +1,124 @@
# cars-bnb-frontend
# Cars BnB App
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There was no open PR for your backend. I tried to review it but this happens when I try to create the database:

image

This means I couldn't review both the backend and the frontend functionality because there was no API running to consume. Also, I wasn't able to run the tests (because I couldn't create the db).

On the frontend, I was able to get to the initial screen, but not any further.

If this is a bug, kindly fix it. If this is not a bug and your app requires something extra not mentioned in your instructions, kindly add it.

Kindly ensure the app works (both backend and frontend) to make a proper review on the functionality.

Since there is no PR for the backend, I'll leave my comments here in this review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your backend API does not have documentation:

image

You could use rswag. It's simple to use, and it adds tests and documentation at the same time. 💪

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your backend project does not have a readme file or a license. Kindly go here and follow this template. 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On your backend, you are using Rspec, but the "test" folder still exists which is used by another test framework. Kindly delete that folder if not using it.


## Welcome! 👋
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • FRONTEND: I could get to the first screen and it's very beautiful. Let's show off your front-end app. Kindly add a screenshot to your readme so everybody can view it. 💪


> #### Cars BnB App
>
> This is a simple app that allows users to rent cars from other users. A user can create a car listing, and other users can rent the car for a specified period of time. The app is built using Ruby on Rails and Bootstrap.
## Screenshots
### Splash Page

![screenshot](./screenshots/screen1.png)
## Car Listings
![screenshot](./screenshots/screen2.png)
## Reservation Page
![screenshot](./screenshots/screen3.png)
## Mobile View
![screenshot](./screenshots/screen4.png)

## Back-end App(API)

> [API](https://github.com/Abdo9826/cars-bnb-backend)

## Built With ✔️

- React 🔥
- redux toolkit
- Bootstrap CSS 😋

## Live link 🙌

[LINK](https://63666fbc53628775d8aaf544--stately-tulumba-fce256.netlify.app/)

## Kanban Board 📝
### Initial Planning
![screenshot](./screenshots/kanban.png)

## Link to kanban board

[Link to Kanban Board](https://github.com/users/Abdo9826/projects/4/views/1)

## Getting Started 🙌

To get a local copy up and running follow these simple example steps.

### Prerequisites

```
node js
npm

```
or
```
yarn
```

### Setup

Clone the repository and change the directory to portfolio

```
`$ git clone https://github.com/Abdo9826/cars-bnb-frontend.git`

`$ cd cars-bnb-frontend`

```

### Install

Install all project dependencies by running the command below

```
` $ npm install` or ` $ yarn install`
```

### Usage

Run

```
`$ npm start or deploy the index.html from the build/public folder`
or
`$ yarn start or deploy the index.html from the build/public folder`
```

### Deployment

- [Visit Application Homepage](#)

### Authors

| 👤 Name | Github | Twitter | LinkedIn |
| --------------- | ---------------------------------------- | ---------------------------------------------------- | -------------------------------------------------------------- |
| Robertson Akpan | [@bobb-rob](https://github.com/bobb-rob) | [@\_\_\_Robertson](https://twitter.com/___Robertson) | [@RobertsonAkpan](https://www.linkedin.com/in/robertsonakpan/) |

| 👤 Name | Github | Twitter | LinkedIn |
| ------- | ------------------------------------ | --------------------------------- | ------------------------------------------ |
| Abdo | [@abdo](https://github.com/Abdo9826) | [@Abdo](https://twitter.com/Abdo) | [@Abdo](https://www.linkedin.com/in/Abdo/) |

| 👤 Name | Github | Twitter | LinkedIn |
| ------- | ------------------------------------ | ---------------------------------- | -------------------------------------------- |
| Sigie | [@ksigei](https://github.com/ksigei) | [@Abdo](https://twitter.com/sigie) | [@sigie](https://www.linkedin.com/in/sigie/) |

| 👤 Name | Github | Twitter | LinkedIn |
| ------------- | ------------------------------------------ | -------------------------------------- | ------------------------------------------------ |
| Shahnawaz Ali | [@Shahnawaz](https://github.com/Shahnawaz) | [@Abdo](https://twitter.com/Shahnawaz) | [@sigie](https://www.linkedin.com/in/Shahnawaz/) |

## 🤝 Contributing

Contributions, issues, and feature requests are welcome!

## Show your support

Give a ⭐️ if you like this project!

## Acknowledgments

- Hat tip to Microverse team for inspiring this project.
- Hat tip to anyone whose code was used
- Hat tip to [Murat Korkmaz](https://www.behance.net/gallery/26425031/Vespa-Responsive-Redesign) for the design inspiration

## 📝 License

All rights reserved.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On the "License" section of your readme, there is no link, and there is no license in your frontend project.

Tips and extra help

Go [here] (https://github.com/microverseinc/readme-template), grab the MIT.md file from that repo, paste it on the root of your project, and link to it in the "License" section of your readme.

That way, your app will be well documented 💪

Loading