-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add Ethena stats distribution indicator #10
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
> | ||
<> | ||
<Trans> | ||
{`This asset is eligible for Sats. Aave Labs does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also put the number of "x" of the sats rewards:
- USDe: x25
- sUSDe: x5
If you find a solution to have this number directly on the rihgt asset (have the x5 only on sUSDe and x25 only on USDe) it's perfect. Otherwise a pending fix would be specify/write every assets rewardss in this message. But the 1 solution would be better of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to create a component similar to the APY component ? So we showcase the points amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I meant, it would be nice to keep the same tooltip component but be able to pass a message/value in parameter in order to showase the number of point (in the cas of Ethena)
-
But if this is not possible, maybe just add the listing of all assets with their respective points can do the job? => or maybe it's too bas in term of UX
-
If these 2 above solution are not suitable, yes maybe a new Incentive component for Ethena with hardcoded points (or even better using an potential Ethena API (if it exists)) would be the solution
General Changes
Implement the indicator for the following campaign: https://app.ethena.fi/liquidity
Developer Notes
Ethena asset kit can be found here
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.example
file as well as the pertinant.github/actions/*
files