Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Delete command Tests for Edge Cases and Validations #97

Merged

Conversation

rizkidelta
Copy link

Expanded test coverage to include boundary conditions and invalid scenarios. Closes #96.

Expanded test coverage to include boundary conditions and invalid scenarios.
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (babe006) to head (0f29ca0).

❗ Current head 0f29ca0 differs from pull request most recent head 770b42f. Consider uploading reports for the commit 770b42f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #97   +/-   ##
=========================================
  Coverage     75.62%   75.62%           
  Complexity      423      423           
=========================================
  Files            70       70           
  Lines          1370     1370           
  Branches        110      110           
=========================================
  Hits           1036     1036           
  Misses          300      300           
  Partials         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

Line was added between tests
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yisiox yisiox merged commit 291845e into AY2324S2-CS2103T-W12-3:master Mar 20, 2024
3 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add delete command tests
2 participants