Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AddressBookParserTest #92

Conversation

aureliony
Copy link

Closes #83

@aureliony aureliony added this to the v1.2b milestone Mar 19, 2024
@aureliony aureliony self-assigned this Mar 19, 2024
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.54%. Comparing base (291845e) to head (b94bd0a).

Files Patch % Lines
...va/seedu/address/logic/util/AddressBookParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     75.62%   75.54%   -0.08%     
+ Complexity      423      422       -1     
============================================
  Files            70       70              
  Lines          1370     1370              
  Branches        110      110              
============================================
- Hits           1036     1035       -1     
- Misses          300      301       +1     
  Partials         34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony marked this pull request as draft March 20, 2024 06:47
Make the class abstract to prevent instantiation as it contains only utility static methods
@aureliony aureliony marked this pull request as ready for review March 20, 2024 06:53
@aureliony aureliony merged commit 6d23b42 into AY2324S2-CS2103T-W12-3:master Mar 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor AddressBookParserTest.java
2 participants