Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG for changes to model component #88

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

aureliony
Copy link

Closes #87

@aureliony aureliony added this to the v1.2b milestone Mar 19, 2024
@aureliony aureliony self-assigned this Mar 19, 2024
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (d64b828) to head (3282942).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage     75.20%   75.20%           
  Complexity      413      413           
=========================================
  Files            68       68           
  Lines          1343     1343           
  Branches        110      110           
=========================================
  Hits           1010     1010           
  Misses          299      299           
  Partials         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yisiox yisiox merged commit 3e89032 into AY2324S2-CS2103T-W12-3:master Mar 20, 2024
5 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Implement View, Create and Delete Order commands to ModelManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG for changes to model component
3 participants