Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add command to support assets #79

Merged
merged 13 commits into from
Mar 19, 2024

Conversation

yisiox
Copy link

@yisiox yisiox commented Mar 17, 2024

Added a field assets as required. GUI is basic, tests are basic (omitted edit related test for now).

Closes #10

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 80.23256% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (f668a1b) to head (209dd38).

Files Patch % Lines
...java/seedu/address/logic/commands/EditCommand.java 76.47% 2 Missing and 2 partials ⚠️
src/main/java/seedu/address/model/asset/Asset.java 81.81% 3 Missing and 1 partial ⚠️
...java/seedu/address/model/person/fields/Assets.java 81.81% 3 Missing and 1 partial ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 3 Missing ⚠️
...c/main/java/seedu/address/model/person/Person.java 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     74.80%   74.90%   +0.10%     
- Complexity      388      408      +20     
============================================
  Files            66       68       +2     
  Lines          1274     1343      +69     
  Branches        103      110       +7     
============================================
+ Hits            953     1006      +53     
- Misses          292      303      +11     
- Partials         29       34       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yisiox yisiox marked this pull request as ready for review March 17, 2024 18:36
@aureliony aureliony added this to the v1.2 milestone Mar 18, 2024
@aureliony aureliony changed the title Update add command with assets Update add command to support assets Mar 18, 2024
Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit 72143bc into AY2324S2-CS2103T-W12-3:master Mar 19, 2024
5 checks passed
@aureliony aureliony modified the milestones: v1.2, v1.2b Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new contacts and assets
2 participants