Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find contacts by name, asset or tag #75

Merged
merged 21 commits into from
Mar 20, 2024

Conversation

aureliony
Copy link

@aureliony aureliony commented Mar 17, 2024

Extend the find command to include tags and assets. Users can now filter persons by keywords that match the corresponding name(s), asset(s) and/or tag(s).

Closes #16

@aureliony aureliony added this to the v1.2b milestone Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.70%. Comparing base (6d29d4f) to head (9e81d6c).

❗ Current head 9e81d6c differs from pull request most recent head 630a40e. Consider uploading reports for the commit 630a40e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
+ Coverage     75.54%   75.70%   +0.15%     
- Complexity      422      427       +5     
============================================
  Files            70       70              
  Lines          1370     1379       +9     
  Branches        110      111       +1     
============================================
+ Hits           1035     1044       +9     
  Misses          301      301              
  Partials         34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony self-assigned this Mar 17, 2024
@aureliony aureliony marked this pull request as draft March 17, 2024 13:30
@aureliony aureliony changed the title Find contacts by name or assets Find contacts by name, asset or tag Mar 17, 2024
@aureliony aureliony marked this pull request as ready for review March 19, 2024 17:18
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good overall, just some possible minor coding standard changes.

@aureliony aureliony requested a review from yisiox March 20, 2024 11:31
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit 1675f9c into AY2324S2-CS2103T-W12-3:master Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find contacts by name, asset or tag
2 participants