-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find contacts by name, asset or tag #75
Find contacts by name, asset or tag #75
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
============================================
+ Coverage 75.54% 75.70% +0.15%
- Complexity 422 427 +5
============================================
Files 70 70
Lines 1370 1379 +9
Branches 110 111 +1
============================================
+ Hits 1035 1044 +9
Misses 301 301
Partials 34 34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good overall, just some possible minor coding standard changes.
src/main/java/seedu/address/model/person/PersonSearchPredicate.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/person/PersonSearchPredicate.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Extend the find command to include tags and assets. Users can now filter persons by keywords that match the corresponding name(s), asset(s) and/or tag(s).
Closes #16