Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readInitialAddressBook() corrupted file test #73

Merged

Conversation

bryanyee33
Copy link

Uses a stub class to properly test for corrupted storage file.
#6

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (8a1d523) to head (a6df56c).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
+ Coverage     74.56%   74.80%   +0.23%     
  Complexity      388      388              
============================================
  Files            66       66              
  Lines          1274     1274              
  Branches        103      103              
============================================
+ Hits            950      953       +3     
+ Misses          295      292       -3     
  Partials         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony added this to the v1.2b milestone Mar 17, 2024
Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit 86b2cbb into AY2324S2-CS2103T-W12-3:master Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants