Refactor Logic component to use enum factory pattern #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All exceptions within CommandType::createCommand are changed to a lower level IllegalArgumentException while the entry point rethrows a higher level ParseException. Delete all command parser tests Removed all command parser tests pending new tests written for command classes which encapsulate the parsing functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage 74.56% 74.56%
+ Complexity 397 388 -9
=========================================
Files 70 66 -4
Lines 1270 1274 +4
Branches 104 103 -1
=========================================
+ Hits 947 950 +3
- Misses 292 295 +3
+ Partials 31 29 -2 ☔ View full report in Codecov by Sentry. |
aureliony
requested changes
Mar 11, 2024
aureliony
approved these changes
Mar 16, 2024
aureliony
pushed a commit
that referenced
this pull request
Apr 15, 2024
Add Order "C" and "D" of CRUD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63
Aim to reduce the number of files that need to be changed to add a new command.
Number of files in Logic reduced.
Moved CliSyntax and Prefix functionality into fields.
Rewrote tests for command parsing.