Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ParserUtil.java #71

Merged

Conversation

aureliony
Copy link

Move parser methods from ParserUtil.java to their respective model classes such as Name, Address, etc.
Closes #70.

@aureliony aureliony requested a review from yisiox March 9, 2024 18:55
@aureliony aureliony added this to the v1.2 milestone Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (fb03371) to head (5315818).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #71   +/-   ##
=========================================
  Coverage     74.56%   74.56%           
  Complexity      397      397           
=========================================
  Files            70       70           
  Lines          1270     1270           
  Branches        104      104           
=========================================
  Hits            947      947           
  Misses          292      292           
  Partials         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yisiox yisiox merged commit bf5cf6f into AY2324S2-CS2103T-W12-3:master Mar 9, 2024
5 checks passed
@aureliony aureliony modified the milestones: v1.2, v1.2b Mar 19, 2024
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Remove ./gradlew test from pre-commit setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ParserUtil.java
2 participants