Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the user guide in accordance with the new feature specification #65

Merged
merged 7 commits into from
Mar 16, 2024

Conversation

aureliony
Copy link

Closes #64

@aureliony aureliony added this to the v1.2 milestone Mar 8, 2024
@aureliony aureliony requested a review from yisiox March 8, 2024 12:45
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (06250eb) to head (e02ac5a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     74.56%   74.56%           
  Complexity      388      388           
=========================================
  Files            66       66           
  Lines          1274     1274           
  Branches        103      103           
=========================================
  Hits            950      950           
  Misses          295      295           
  Partials         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but perhaps some nits to fix

Edit: on further scrutiny, I think list should be included.

@aureliony aureliony requested a review from yisiox March 10, 2024 11:23
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't use the term id to refer to contacts but rather it works by index.

@aureliony aureliony requested a review from yisiox March 11, 2024 13:17
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yisiox yisiox merged commit 8a1d523 into AY2324S2-CS2103T-W12-3:master Mar 16, 2024
5 checks passed
@aureliony aureliony modified the milestones: v1.2, v1.2b Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UG with newly discussed minimum required features
2 participants