Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better DG requirements #61

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

yisiox
Copy link

@yisiox yisiox commented Mar 7, 2024

Hopefully irons out the specifics of the scope and terminology. Closes #69.

Target Users

Edit phrasing to match tP constraints' phrasing. Notably removed the requirement for the target user to be familiar with CLI. They only need to prefer typing, the interface should reasonably be simple enough to be picked up by such a user, and not require experienced CLI users.

Value Proposition

Explained the type of contacts the target user may need to track, and the shortfalls of usual software like Excel. Our application thus delivers a more targeted solution.

User Stories

Swapped use of the turn PoC to contacts to be more general. Added paste to clipboard shortcut as a nice to have functionality. Downgraded tags to nice to have.

Use Cases

Update to new required features.

Glossary

Updated as necessary with any new terms used.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (bf5cf6f) to head (584c77d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     74.56%   74.56%           
  Complexity      397      397           
=========================================
  Files            70       70           
  Lines          1270     1270           
  Branches        104      104           
=========================================
  Hits            947      947           
  Misses          292      292           
  Partials         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yisiox yisiox marked this pull request as ready for review March 9, 2024 12:18
Copy link

@fivetran-tangyetong fivetran-tangyetong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to our DG to adhere to our use cases and requirements. LGTM.

@yisiox yisiox merged commit 3674f9f into AY2324S2-CS2103T-W12-3:master Mar 11, 2024
5 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DG is inconsistent since features have changed
2 participants