Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logic components #60

Merged

Conversation

bryanyee33
Copy link

Change AddressBookParser.java::parseCommand() to static command.
Remove CommandResult.java in favour of String results, to make it less error prone and more readable.

Updates #54

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.75%. Comparing base (3b04b21) to head (97b9b3c).

❗ Current head 97b9b3c differs from pull request most recent head 4d0d4af. Consider uploading reports for the commit 4d0d4af to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     74.30%   73.75%   -0.55%     
+ Complexity      405      392      -13     
============================================
  Files            70       69       -1     
  Lines          1292     1269      -23     
  Branches        107      105       -2     
============================================
- Hits            960      936      -24     
- Misses          302      303       +1     
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony added this to the v1.2 milestone Mar 7, 2024
@aureliony aureliony linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aureliony

This comment was marked as duplicate.

Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanyee33 bryanyee33 merged commit 31ebb75 into AY2324S2-CS2103T-W12-3:master Mar 8, 2024
3 checks passed
@aureliony aureliony modified the milestones: v1.2, v1.2b Mar 19, 2024
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the existing codebase: logic component
3 participants