-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logic components #60
Refactor logic components #60
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
============================================
- Coverage 74.30% 73.75% -0.55%
+ Complexity 405 392 -13
============================================
Files 70 69 -1
Lines 1292 1269 -23
Branches 107 105 -2
============================================
- Hits 960 936 -24
- Misses 302 303 +1
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change AddressBookParser.java::parseCommand() to static command.
Remove CommandResult.java in favour of String results, to make it less error prone and more readable.
Updates #54