Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Storage components #55

Merged

Conversation

bryanyee33
Copy link

@bryanyee33 bryanyee33 commented Mar 6, 2024

Move MainApp.java::initModelManager() to StorageManager.java::readInitialAddressBook() to increase cohesion.
Move saveAddressBook exception handling to JsonAddressBookStorage.java.
Add StorageException.java.

Closes #6

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 74.56%. Comparing base (31ebb75) to head (5b9a802).

Files Patch % Lines
.../seedu/address/storage/JsonAddressBookStorage.java 50.00% 4 Missing ⚠️
...ain/java/seedu/address/storage/StorageManager.java 60.00% 3 Missing and 1 partial ⚠️
...u/address/storage/exceptions/StorageException.java 0.00% 4 Missing ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 3 Missing ⚠️
src/main/java/seedu/address/ui/CommandBox.java 0.00% 1 Missing ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
+ Coverage     73.75%   74.56%   +0.80%     
- Complexity      392      397       +5     
============================================
  Files            69       70       +1     
  Lines          1269     1270       +1     
  Branches        105      104       -1     
============================================
+ Hits            936      947      +11     
+ Misses          303      292      -11     
- Partials         30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanyee33 bryanyee33 changed the title Refactor Storage.java::readInitialAddressBook() Refactor Storage components Mar 6, 2024
@aureliony aureliony added this to the v1.2 milestone Mar 7, 2024
Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit fb03371 into AY2324S2-CS2103T-W12-3:master Mar 8, 2024
4 of 5 checks passed
@aureliony aureliony modified the milestones: v1.2, v1.2b Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the existing codebase: storage and model components
3 participants