-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Storage components #55
Refactor Storage components #55
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
============================================
+ Coverage 73.75% 74.56% +0.80%
- Complexity 392 397 +5
============================================
Files 69 70 +1
Lines 1269 1270 +1
Branches 105 104 -1
============================================
+ Hits 936 947 +11
+ Misses 303 292 -11
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Move MainApp.java::initModelManager() to StorageManager.java::readInitialAddressBook() to increase cohesion.
Move saveAddressBook exception handling to JsonAddressBookStorage.java.
Add StorageException.java.
Closes #6