Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overall code quality #264

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Improve overall code quality #264

merged 9 commits into from
Apr 12, 2024

Conversation

aureliony
Copy link

@aureliony aureliony commented Apr 11, 2024

Closes #160
Closes #265

@aureliony aureliony added this to the v1.4 milestone Apr 11, 2024
@aureliony aureliony self-assigned this Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.93%. Comparing base (b4ddc7a) to head (8260eb4).

Files Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
- Coverage     76.94%   76.93%   -0.01%     
+ Complexity      515      514       -1     
============================================
  Files            75       75              
  Lines          1596     1591       -5     
  Branches        143      143              
============================================
- Hits           1228     1224       -4     
+ Misses          338      337       -1     
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony marked this pull request as ready for review April 12, 2024 10:16
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanyee33 bryanyee33 merged commit 558851f into master Apr 12, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addressBookFilePath in preferences.json is incorrect Improve code quality
2 participants