Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG and Ui.png for release v1.3 #176

Merged
merged 27 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
19db666
Update UG introduction
yisiox Apr 3, 2024
2b0600f
Merge updates to UG from master
yisiox Apr 3, 2024
2135545
UserGuide.md: Update for readability
yisiox Apr 3, 2024
d43652c
Update FAQ of the UG
yisiox Apr 3, 2024
3e86b0c
Update Ui.png
aureliony Apr 4, 2024
1df9726
Add images for setup in UG
fivetran-tangyetong Apr 4, 2024
dd37589
Add more information to add command
fivetran-tangyetong Apr 4, 2024
83fefd1
Resolve merge conflict from master
yisiox Apr 4, 2024
a45d135
Merge branch 'release-v1.3-ug' of github.com:AY2324S2-CS2103T-W12-3/t…
yisiox Apr 4, 2024
c73bef7
UserGuide.md: Add items to glossary
yisiox Apr 4, 2024
fc20bd4
Change Phone regex and update UG
bryanyee33 Apr 4, 2024
b6ab9fe
Merge branch 'release-v1.3-ug' of https://github.com/AY2324S2-CS2103T…
bryanyee33 Apr 4, 2024
868aa9f
Update table of contents
bryanyee33 Apr 4, 2024
7a31ce9
Update features section of user guide
yisiox Apr 4, 2024
f1d4231
Merge changes from master
yisiox Apr 4, 2024
17320df
Add tutorials
rizkidelta Apr 4, 2024
f94cceb
Merge branch 'release-v1.3-ug' of https://github.com/AY2324S2-CS2103T…
rizkidelta Apr 4, 2024
0287eb1
Add page breaks to beautify PDF
aureliony Apr 4, 2024
5509702
Fix image sizes
aureliony Apr 4, 2024
dfa09c6
Fix image alignment issues
aureliony Apr 4, 2024
5aadfde
Fix command history link
bryanyee33 Apr 4, 2024
703911c
Merge branch 'release-v1.3-ug' of https://github.com/AY2324S2-CS2103T…
bryanyee33 Apr 4, 2024
bf5490a
Fix image alignment issues
aureliony Apr 4, 2024
298b51b
Improve PDF style
aureliony Apr 4, 2024
fe032ec
Fix extra bullet point
bryanyee33 Apr 4, 2024
b4bcad7
Resolve merge conflicts
aureliony Apr 4, 2024
79aafd1
Merge remote-tracking branch 'refs/remotes/origin/release-v1.3-ug' in…
aureliony Apr 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
539 changes: 439 additions & 100 deletions docs/UserGuide.md

Large diffs are not rendered by default.

Binary file modified docs/images/Ui.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/example-add-after-fail.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/example-add-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/example-add-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/navigating-gui.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/setup-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/setup-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/setup-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/setup-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-add-1.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-add-2.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-add-3.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-edit-1.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-edit-2.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-edit-3.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-editA-1.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-editA-2.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-find-1.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/tutorial-find-2.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 0 additions & 3 deletions docs/stylesheets/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,6 @@ mark {
.btn {
font-size: 0.65rem !important;
}
img {
zoom: 0.8; /* might not work on some browsers */
}
}

h1,
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/seedu/address/model/person/fields/Phone.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
public class Phone implements Field {

public static final Prefix PREFIX_PHONE = new Prefix("p\\");
private static final String MESSAGE_CONSTRAINTS =
"Phone numbers should only contain numbers, and it should be at least 3 digits long";
private static final String VALIDATION_REGEX = "\\d{3,}";
private static final String MESSAGE_CONSTRAINTS = "Phone numbers should only contain numbers,"
+ "'+', '-', ',' and spaces, and it should be at least 3 characters long";
private static final String VALIDATION_REGEX = "[\\d\\-\\s+,]{3,}";
private final String phone;

/**
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/seedu/address/model/tag/Tag.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
*/
public class Tag {

private static final String MESSAGE_CONSTRAINTS = "Tags cannot contain '\\', and should not be blank";
private static final String MESSAGE_CONSTRAINTS = "Tags cannot contain '\\', can only consist of"
+ "alphabets and numbers, and should not be blank";
private static final String VALIDATION_REGEX = "\\p{Alnum}+";

private final String tagName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
public class PhoneTest {

private static final String WHITESPACE = " \t\r\n";
private static final String INVALID_PHONE = "+651234";
private static final String VALID_PHONE = "123456";
private static final String INVALID_PHONE = "+6512345678 (home)";
private static final String VALID_PHONE = "+65 1234 5678, +98-4321-5432-42";

@Test
public void constructor_null_throwsNullPointerException() {
Expand All @@ -26,7 +26,8 @@ public void constructor_invalidPhone_throwsIllegalArgumentException() {
assertThrows(IllegalArgumentException.class, () -> new Phone("91")); // less than 3 numbers
assertThrows(IllegalArgumentException.class, () -> new Phone("phone")); // non-numeric
assertThrows(IllegalArgumentException.class, () -> new Phone("9011p041")); // alphabets within digits
assertThrows(IllegalArgumentException.class, () -> new Phone("9312 1534")); // spaces within digits
assertThrows(IllegalArgumentException.class, () -> new Phone("9312_1534")); // underscore within digits
assertThrows(IllegalArgumentException.class, () -> new Phone("93121534(home), 94387573(office)")); // brackets
}

@Test
Expand Down