Implement substring search feature #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fuzzy search functionality to the existing find command. This enhancement allows for more forgiving search queries, improving user experience by returning relevant results even when the search term isn't an exact match.
Implemented Fuzzy search so users can easily search within the system even if the user mistype a few words, so that.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
============================================
- Coverage 77.23% 77.01% -0.22%
- Complexity 513 515 +2
============================================
Files 75 75
Lines 1603 1597 -6
Branches 143 143
============================================
- Hits 1238 1230 -8
Misses 337 337
- Partials 28 30 +2 ☔ View full report in Codecov by Sentry. |
aureliony
requested changes
Mar 31, 2024
src/main/java/seedu/address/model/person/PersonMatchesKeywordsPredicate.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/person/PersonMatchesKeywordsPredicate.java
Outdated
Show resolved
Hide resolved
Implemented Fuzzy search so users can easily search within the system even if the user mistype a few words, so that and added tests to test fuzzy functionality.
bc823f1 to
92daf4a
Compare
81b1f7f to
a5dc75a
Compare
aureliony
approved these changes
Apr 4, 2024
yisiox
reviewed
Apr 4, 2024
src/main/java/seedu/address/model/person/PersonMatchesQueryPredicate.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented substring search to replace the previous keyword search feature. Search is now more forgiving with whitespaces, allowing partial matches.
Closes #19