Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GUI #165

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Improve GUI #165

merged 4 commits into from
Apr 2, 2024

Conversation

fivetran-tangyetong
Copy link

@fivetran-tangyetong fivetran-tangyetong commented Mar 31, 2024

GUI follows legacy AB3 mockup

Improvements made to suit AssetBook needs

Closes #22, #118 and #163

GUI follows legacy AB3 mockup

Improvements made to suit AssetBook needs
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.83%. Comparing base (23e388a) to head (683aa99).

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
- Coverage     78.98%   78.83%   -0.16%     
  Complexity      509      509              
============================================
  Files            73       73              
  Lines          1542     1545       +3     
  Branches        136      136              
============================================
  Hits           1218     1218              
- Misses          298      301       +3     
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony requested a review from bryanyee33 March 31, 2024 06:36
@aureliony aureliony added this to the v1.3 milestone Mar 31, 2024
Window size small currently, increased to improve feel ok application
Text area does not wrap text, leading to sideway navigation

Window size increased to feel more comfortable, and wrapping enabled to stop side scrolling
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nits.

Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work on the icons!

@bryanyee33 bryanyee33 merged commit 98bd7cc into master Apr 2, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beautiful user interface
3 participants