Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement command history feature #162

Merged
merged 10 commits into from
Apr 2, 2024
Merged

Implement command history feature #162

merged 10 commits into from
Apr 2, 2024

Conversation

aureliony
Copy link

Closes #137

@aureliony aureliony added this to the v1.3 milestone Mar 29, 2024
@aureliony aureliony self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 32.83582% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 77.74%. Comparing base (98bd7cc) to head (76c02be).

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 21 Missing ⚠️
src/main/java/seedu/address/ui/CommandBox.java 0.00% 19 Missing ⚠️
.../main/java/seedu/address/logic/CommandHistory.java 85.00% 0 Missing and 3 partials ⚠️
...rc/main/java/seedu/address/logic/LogicManager.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #162      +/-   ##
============================================
- Coverage     78.83%   77.74%   -1.10%     
- Complexity      509      518       +9     
============================================
  Files            73       75       +2     
  Lines          1545     1595      +50     
  Branches        136      143       +7     
============================================
+ Hits           1218     1240      +22     
- Misses          301      326      +25     
- Partials         26       29       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony marked this pull request as ready for review March 29, 2024 10:26
@aureliony aureliony changed the title Implement command history Implement command history feature Mar 29, 2024
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few suggestions.

@aureliony aureliony requested a review from bryanyee33 April 2, 2024 13:24
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bryanyee33 bryanyee33 merged commit ff27645 into master Apr 2, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Up and down shortcut to view previous commands
2 participants