Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage #153

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Improve code coverage #153

merged 7 commits into from
Mar 28, 2024

Conversation

aureliony
Copy link

Closes #91

@aureliony aureliony added this to the v1.3 milestone Mar 28, 2024
@aureliony aureliony self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.89%. Comparing base (bde432f) to head (d8de4f1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
+ Coverage     75.83%   78.89%   +3.05%     
- Complexity      461      488      +27     
============================================
  Files            72       72              
  Lines          1469     1464       -5     
  Branches        119      119              
============================================
+ Hits           1114     1155      +41     
+ Misses          318      285      -33     
+ Partials         37       24      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits.

@aureliony aureliony requested a review from bryanyee33 March 28, 2024 10:42
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bryanyee33 bryanyee33 merged commit b73766c into master Mar 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert tests from using assertNotEquals() back to assertFalse(object.equals(...))
2 participants