Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a warning message if database is corrupted #146

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Show a warning message if database is corrupted #146

merged 13 commits into from
Mar 28, 2024

Conversation

aureliony
Copy link

Closes #116
Closes #129

@aureliony aureliony added this to the v1.3 milestone Mar 26, 2024
@aureliony aureliony self-assigned this Mar 26, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.64706% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 75.83%. Comparing base (e9b6a5a) to head (4ec37e8).

Files Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 17 Missing ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 9 Missing ⚠️
src/main/java/seedu/address/ui/UiManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
- Coverage     76.38%   75.83%   -0.56%     
- Complexity      460      461       +1     
============================================
  Files            72       72              
  Lines          1457     1469      +12     
  Branches        119      119              
============================================
+ Hits           1113     1114       +1     
- Misses          307      318      +11     
  Partials         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bryanyee33
bryanyee33 requested changes Mar 28, 2024
View reviewed changes
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit.

@aureliony aureliony requested a review from bryanyee33 March 28, 2024 10:28
@aureliony aureliony force-pushed the 116-show-error-if-json-corrupted branch from ae616f1 to aba0d11 Compare March 28, 2024 10:29
bryanyee33
bryanyee33 approved these changes Mar 28, 2024
View reviewed changes
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit bde432f into master Mar 28, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanyee33 bryanyee33 bryanyee33 approved these changes

Assignees

@aureliony aureliony

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Invalid json may cause loss of data Show a warning message if database is corrupted
2 participants
@aureliony @bryanyee33