Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use case for adding person through json #143

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Conversation

aureliony
Copy link

Related to #129

@aureliony aureliony added this to the v1.3 milestone Mar 26, 2024
@aureliony aureliony self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.89%. Comparing base (b73766c) to head (def14a9).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage     78.89%   78.89%           
  Complexity      488      488           
=========================================
  Files            72       72           
  Lines          1464     1464           
  Branches        119      119           
=========================================
  Hits           1155     1155           
  Misses          285      285           
  Partials         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony marked this pull request as draft March 26, 2024 11:38
@aureliony aureliony marked this pull request as ready for review March 26, 2024 12:17
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the use case resume steps are incorrect.

@aureliony aureliony requested a review from bryanyee33 March 28, 2024 11:01
Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bryanyee33 bryanyee33 merged commit 6e36358 into master Mar 28, 2024
8 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants