Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up code #135

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Tidy up code #135

merged 4 commits into from
Mar 26, 2024

Conversation

bryanyee33
Copy link

Removes unnecessary print statement.
Removes repetitive requireNonNull() checks.

Some parameters are checked for non-null multiple times when passed
into another method, while some are devoid of them.

This reduces consistency between methods, and possibly reduces
performance.

Remove requireNonNull() for wrapper methods, and only check in
final method where parameter is used.
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.11%. Comparing base (2f7acf2) to head (aba9b39).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
- Coverage     76.21%   76.11%   -0.10%     
  Complexity      450      450              
============================================
  Files            71       71              
  Lines          1442     1436       -6     
  Branches        119      119              
============================================
- Hits           1099     1093       -6     
  Misses          306      306              
  Partials         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony added this to the v1.3 milestone Mar 26, 2024
Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit 7264763 into master Mar 26, 2024
8 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants