Add Copy Command
#131
Merged
Add Copy Command
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently does not support copy to clipboard functionality Copy to clipboard functionality added alongside relevant tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
============================================
+ Coverage 78.89% 78.98% +0.09%
- Complexity 488 509 +21
============================================
Files 72 73 +1
Lines 1464 1542 +78
Branches 119 136 +17
============================================
+ Hits 1155 1218 +63
- Misses 285 298 +13
- Partials 24 26 +2 ☔ View full report in Codecov by Sentry. |
aureliony
requested changes
Mar 24, 2024
Code currently does not conform to certain conventions required Unused print statements removed and defensiveness of code maintained in new logic added
ea1cc53 to
08172ca
Compare
aureliony
requested changes
Mar 26, 2024
src/test/java/seedu/address/logic/commands/CopyCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/commands/CopyCommandTest.java
Outdated
Show resolved
Hide resolved
CopyCommandTest currently does not use default values in personbuilder Default values in PersonBuilder used in test, and refactor for new line spacing
copy command should only work on one field and without prepending the field name
aureliony
requested changes
Mar 27, 2024
CopyCommand returns multiple fields and field names Update to return only field and no field name
aureliony
requested changes
Mar 28, 2024
Test coverage currently too little Added more tests
aureliony
pushed a commit
that referenced
this pull request
Apr 15, 2024
Modify links to point to repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently does not support copy to clipboard functionality
Copy to clipboard functionality added alongside relevant tests
Closes #121