Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Asset fields and change method of editing #128

Merged
merged 32 commits into from
Apr 4, 2024
Merged

Conversation

yisiox
Copy link

@yisiox yisiox commented Mar 24, 2024

Updated asset to include a id and location field (changed, see below)

How it works: The user inputs assets in the format A/NAME[#ID][@LOCATION]. In other words, id and location are optional, and must be delimited by # and @.

Snippet of test code for reference (only the first 4 are valid asset descriptions)
image

GUI display is still rudimentary
image

Update to Update

Location field has been removed as discussed. The validation for assets is now \s*([^#\s]+\s*)+(#(\s*[^#\s]+\s*)+)?

Update to Update to Update

Assets only have names. Prefixes are changed to use '\' instead. Person names are allowed to have special characters except the backslash.

Updated edita to asset

As discussed, edita has been renamed to asset in order to maintain a set of commands in "natural language".

Tests

Asset test has been updated to match.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.99%. Comparing base (3f03477) to head (0b101ce).

Files Patch % Lines
...java/seedu/address/logic/commands/CommandType.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
- Coverage     77.01%   76.99%   -0.03%     
  Complexity      515      515              
============================================
  Files            75       75              
  Lines          1597     1595       -2     
  Branches        143      143              
============================================
- Hits           1230     1228       -2     
  Misses          337      337              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yisiox yisiox marked this pull request as ready for review March 24, 2024 18:25
@aureliony aureliony added this to the v1.3 milestone Mar 25, 2024
@aureliony aureliony linked an issue Mar 26, 2024 that may be closed by this pull request
@yisiox
Copy link
Author

yisiox commented Apr 3, 2024

Also fixes #169

Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user guide also needs to be updated.

@aureliony aureliony linked an issue Apr 3, 2024 that may be closed by this pull request
@yisiox
Copy link
Author

yisiox commented Apr 3, 2024

The user guide also needs to be updated.

Will be fixed in a separate PR.

@aureliony aureliony merged commit 86b2cb6 into master Apr 4, 2024
8 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow / character for names Review implementation of Asset
3 participants