-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Asset fields and change method of editing #128
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
============================================
- Coverage 77.01% 76.99% -0.03%
Complexity 515 515
============================================
Files 75 75
Lines 1597 1595 -2
Branches 143 143
============================================
- Hits 1230 1228 -2
Misses 337 337
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Also fixes #169 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user guide also needs to be updated.
Will be fixed in a separate PR. |
…tp into 124-update-asset
…tp into 124-update-asset
Updated asset to include a id and location field (changed, see below)
How it works: The user inputs assets in the formatA/NAME[#ID][@LOCATION]
. In other words, id and location are optional, and must be delimited by#
and@
.Snippet of test code for reference (only the first 4 are valid asset descriptions)GUI display is still rudimentary

Update to Update
Location field has been removed as discussed. The validation for assets is now\s*([^#\s]+\s*)+(#(\s*[^#\s]+\s*)+)?
Update to Update to Update
Assets only have names. Prefixes are changed to use '\' instead. Person names are allowed to have special characters except the backslash.
Updated edita to asset
As discussed,
edita
has been renamed toasset
in order to maintain a set of commands in "natural language".Tests
Asset test has been updated to match.