Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG for Logic component #100

Merged
merged 8 commits into from
Mar 20, 2024

Conversation

yisiox
Copy link

@yisiox yisiox commented Mar 20, 2024

Changed the puml and description to match the new logic. Closes #74

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (6d23b42) to head (caa5e52).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #100   +/-   ##
=========================================
  Coverage     75.54%   75.54%           
  Complexity      422      422           
=========================================
  Files            70       70           
  Lines          1370     1370           
  Branches        110      110           
=========================================
  Hits           1035     1035           
  Misses          301      301           
  Partials         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony added this to the v1.2 milestone Mar 20, 2024
@aureliony aureliony merged commit 6d29d4f into AY2324S2-CS2103T-W12-3:master Mar 20, 2024
5 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG for Logic component
2 participants