forked from nus-cs2103-AY2324S2/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG for Logic component #100
Merged
aureliony
merged 8 commits into
AY2324S2-CS2103T-W12-3:master
from
yisiox:74-update-dg-logic
Mar 20, 2024
Merged
Update DG for Logic component #100
aureliony
merged 8 commits into
AY2324S2-CS2103T-W12-3:master
from
yisiox:74-update-dg-logic
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage 75.54% 75.54%
Complexity 422 422
=========================================
Files 70 70
Lines 1370 1370
Branches 110 110
=========================================
Hits 1035 1035
Misses 301 301
Partials 34 34 ☔ View full report in Codecov by Sentry. |
aureliony
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aureliony
pushed a commit
that referenced
this pull request
Apr 15, 2024
Fix nested and unecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the puml and description to match the new logic. Closes #74