Modify Regex for Sets #72
Conversation
Codecov ReportBase: 72.10% // Head: 72.10% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage 72.10% 72.10%
Complexity 399 399
=========================================
Files 70 70
Lines 1233 1233
Branches 125 125
=========================================
Hits 889 889
Misses 312 312
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
docs/UserGuide.md
Outdated
| * **Exercise** : Physical activity done in a regular gym that is planned, structured, and repetitive and has as a final | ||
| or an intermediate objective to the improvement or maintenance of physical fitness |
There was a problem hiding this comment.
Seems to be too long; if ultimately our goal is to emphasise that we require weight/sets/reps to be logged, perhaps "structured and repetitive" is enough.
Also debatable if we want to include the objective of exercise in the definition.
Maybe "physical activity, done in a regular gym, that is structured and repetitive, usually/possibly involving some weights (carried out to sustain or improve health and fitness)"
There was a problem hiding this comment.
Sounds great, will make the necessary changes
There was a problem hiding this comment.
I don't think the purpose of exercise is necessary, rather keep it concise.
Perhaps consider. "Physical activity that can be done in groups of successive repetitions, possibly involving some external weights."
Modify REGEX for Sets to ensure sets only accept up to 3 digit positive integers with no leading zeroes.
Include more test statements for JUnit test for Sets.
Update command example and exercise definition in UserGuide.