Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer guide for pin command #90

Merged

Conversation

yucheng11122017
Copy link

@yucheng11122017 yucheng11122017 commented Oct 21, 2021

Contributes to #88

@yucheng11122017 yucheng11122017 marked this pull request as ready for review October 21, 2021 16:32
participant ":Model" as Model MODEL_COLOR
end box

[-> LogicManager : execute("pin 1")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands also have an execute method which might get confusing
consider labelling this as user input instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I added UI inside so its clearer :)

@codecov-commenter
Copy link

Codecov Report

Merging #90 (a9d2205) into master (127cf7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #90   +/-   ##
=========================================
  Coverage     74.31%   74.31%           
  Complexity      540      540           
=========================================
  Files            92       92           
  Lines          1616     1616           
  Branches        179      179           
=========================================
  Hits           1201     1201           
  Misses          354      354           
  Partials         61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127cf7b...a9d2205. Read the comment docs.

Copy link

@leezhixuan leezhixuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yucheng11122017 yucheng11122017 merged commit c5807bc into AY2122S1-CS2103-F09-4:master Oct 22, 2021
@yucheng11122017 yucheng11122017 added this to the v1.3 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants