Improve code quality

AY2122S1-CS2103-F09-4 · Oct 19, 2021 · a37b8e1 · a37b8e1
1 parent 83fc702
commit a37b8e1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/main/java/seedu/address/model/person/Person.java b/src/main/java/seedu/address/model/person/Person.java
@@ -44,6 +44,14 @@ public Name getName() {
         return name;
     }
 
+    public String getFullName() {
+        return name.fullName;
+    }
+
+    public String getPhoneNumber() {
+        return phone.value;
+    }
+
     public Phone getPhone() {
         return phone;
     }

diff --git a/src/main/java/seedu/address/ui/BirthdayReminderCard.java b/src/main/java/seedu/address/ui/BirthdayReminderCard.java
@@ -37,10 +37,11 @@ public class BirthdayReminderCard extends UiPart<Region> {
     public BirthdayReminderCard(Person person) {
         super(FXML);
         this.person = person;
-        name.setText(person.getName().fullName);
-        phone.setText(person.getPhone().value);
+        name.setText(person.getFullName());
+        phone.setText(person.getPhoneNumber());
         Optional<Birthday> possibleBirthday = person.getBirthday();
-        birthday.setText(possibleBirthday.map(Birthday::display).orElse(""));
+        assert possibleBirthday.isPresent();
+        birthday.setText(possibleBirthday.map(Birthday::display).get());
     }
 
     @Override