Command and Parser #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiuweehan
requested changes
Sep 28, 2019
There was a problem hiding this comment.
Good job with refactoring the code, especially for the default values and regexes!
The only major issue is that it currently throws an error when the user omits optional prefixes, which can be easily fixed by first checking if the prefix exists and then using the default values if they don't.
Besides that, it would be good to use the existing constructors instead of creating new ones.
|
Lastly do make sure that the checks are passing~ |
tiuweehan
approved these changes
Sep 29, 2019
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26 and #31 .