Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter fitter #90

Merged
merged 18 commits into from
Feb 13, 2024
Merged

Add new parameter fitter #90

merged 18 commits into from
Feb 13, 2024

Conversation

ma-sadeghi
Copy link
Collaborator

@ma-sadeghi ma-sadeghi commented Feb 13, 2024

Closes #84

This PR adds a new parameter fitter. It still uses the same method as impedance.py, but is 20x ~10x faster, so we can afford to brute-force our way into a pottentially good fit.

It also standardizes the circuit function signature: Used to be fn(p, freq), now is fn(freq, p) to be intuitive. Also all functions that accept Z and freq, now accept it in the following order: freq, Z, again to be intuitive.

@ma-sadeghi ma-sadeghi added the enhancement New feature or request label Feb 13, 2024
@ma-sadeghi ma-sadeghi merged commit 0628cc4 into develop Feb 13, 2024
6 checks passed
@ma-sadeghi ma-sadeghi deleted the enh/optimizer-fitter branch February 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose maximum function evals maxfev as input arg for fit_circuit_parameters
1 participant