Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that the logo animation is stopped after dismissing the share screen #5

Closed
wants to merge 1 commit into from
Closed

Conversation

mshibanami
Copy link

Hi, thanks for publishing this great app and its source code!

Quite nitpicking but I noticed that the logo animation is stopped when I dismissed the share screen.

This might be Lottie's bug since this is happening even autoPlay=true is set. Please feel free to close this pull request if you know a better solution.

Before After
Screen Recording 2020-06-20 at 1 33 32 pm Screen Recording 2020-06-20 at 1 32 06 pm

Environments where I reproduced

  • App Version: 1.0.28
  • Devices:
    • [Emulator] Pixel 3 API 29
    • [Physical Device] OnePlus6T Oxygen OS 10.3.4 (Android 10)

@covidsafe-support
Copy link
Contributor

Hi @mshibanami , thanks for your PR. We’ve created an item for this in our backlog for our developers to action. We will update this PR to let you know when we’ve made progress or if we have any questions.

@covidsafe-support
Copy link
Contributor

Hi @mshibanami - just letting you know we have released v1.0.33 of COVIDSafe for Android which includes your fix:

home_header_picture_setup_complete.resumeAnimation()

This PR will be closed as we only merge in full releases to this repo (which we have done with your fix).

Thanks again for your PR!

@mshibanami
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants