Prevent dome slaving calculations from sending NaN to the downstream …

…dome driver.

Fixed AxisConverter unit tests
Bumped version to 6.5.1.5

DeviceHub/DeviceManagers/DomeManager.cs

@@ -614,6 +614,40 @@ private void SlaveDomePointing( Point scopePosition, double localHourAngle, Pier
 
 			Point domeAltAz = GetDomeCoord( scopePosition, localHourAngle, sideOfPier );
 			double targetAzimuth = domeAltAz.X;
+			double targetAltitude = domeAltAz.Y;
+
+			bool targetsValid = true;
+
+			// Validate the calculated azimuth appears sane.
+			// If the scope position is NaN or any other input to the slaving calculation is NaN then
+			// the resultant targetAlt and targetAz could also be NaN. We do not want to send NaN to
+			// the dome, even though it should reject it.
+
+			if ( Double.IsNaN(targetAzimuth) || targetAzimuth < 0.0 || targetAzimuth > 360.0 )
+			{
+				targetsValid = false;
+				LogActivityLine( ActivityMessageTypes.Commands
+								, "An invalid azimuth value ({0:f2}) was calculated...short circuiting the slew"
+								, targetAzimuth );
+			}
+
+			// Validate the calculated altitude appears sane.
+			// Using 180 degrees for the upper limit for a clamshell type of dome that may be able to open to 180.
+
+			if ( Double.IsNaN( targetAltitude) || targetAltitude < 0.0 || targetAltitude > 180.0 )
+			{
+				targetsValid = false;
+				LogActivityLine( ActivityMessageTypes.Commands
+								, "An invalid altitude value ({0:f2}) was calculated...short circuiting the slew"
+								, targetAltitude );
+			}
+
+			// If either the target azimuth or altitude are invalid, return without slewing the dome!!!
+
+			if ( !targetsValid )
+			{
+				return;
+			}
 
 			LogActivityLine( ActivityMessageTypes.Commands, "The calculated dome position is Az: {0:f2}, Alt: {1:f2}."
 							, domeAltAz.X, domeAltAz.Y );
@@ -636,8 +670,6 @@ private void SlaveDomePointing( Point scopePosition, double localHourAngle, Pier
 				}, CancellationToken.None );
 			}
 
-			double targetAltitude = domeAltAz.Y;
-
 			if ( Capabilities.CanSetAltitude && Status.Altitude < targetAltitude )
 			{
 				LogActivityLine( ActivityMessageTypes.Commands

Inno Setup/ASCOM Device Hub Setup.iss

@@ -4,7 +4,7 @@
 ;
 
 #define MyAppName "ASCOM.DeviceHub"
-#define MyAppVersion "6.5.1.4"
+#define MyAppVersion "6.5.1.5"
 #define MyDestSubdirName "DeviceHub"
 ; #define MyPlatformRoot "D:\Github Repos\ASCOMPlatform\"
 #define MyPlatformRoot "D:\My Projects\Visual Studio 2019\Ascom\"

ProductAssemblyInfo.cs

@@ -20,4 +20,4 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion( "6.5.1.4" )]
+[assembly: AssemblyVersion( "6.5.1.5" )]

Unit Tests/Test Classes/Telescope Tests/AxisConvertersTests.cs

@@ -21,7 +21,7 @@ public class AxisConvertersTests
 		private int _testRaHours = 12;
 		private int _testRaMinutes = 20;
 		private int _testRaSeconds = 44;
-		private string _testRaString = "12:20:44";
+		private string _testRaString = "+12:20:44";
 
 		private decimal _testValueRoundUp = 16.6499917m;
 		private int _testDegreesRoundUp = 16;