Hub callback bug fixes & invokeMethod improvements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invokeMethod now supports upto 10 arguments - statusChangeCallback type changes to dynamic (Possible fix for a reported issue) - Hub method callback type changed to Any (Android) - Android gradle updates Signed-off-by: Ayon Das <ayantorres@gmail.com>
Signed-off-by: Ayon Das <ayantorres@gmail.com>
…method name (iOS testing WIP) Signed-off-by: Ayon Das <ayantorres@gmail.com>
- HubCallback now returns the methodName and Result - invokeMethod now can take any number of arguments - Few other minor fixes Signed-off-by: Ayon Das <ayantorres@gmail.com>
Signed-off-by: Ayon Das <ayantorres@gmail.com>
Signed-off-by: Ayon Das <ayantorres@gmail.com>
- subscribeToHubMethod will be dropped - Hub methods list added, this will be the new way to subscribe to hubs Signed-off-by: Ayon Das <ayantorres@gmail.com>
- Update documentation Signed-off-by: Ayon Das <ayantorres@gmail.com>
Signed-off-by: Ayon Das <ayantorres@gmail.com>
Signed-off-by: Ayon Das <ayantorres@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR:
Fix a issue where hub callback only accepting strings.
Hub callback now returns the message as well as the subscribed method name.
Make invokeMethod generic.
As many arguments as you want in invokeMethod.
Update documentation.
Note: This PR should be merged after the new version is pushed to the Pub.