Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix changelog rendering #43

Merged
merged 2 commits into from
Apr 6, 2020
Merged

🐛 Fix changelog rendering #43

merged 2 commits into from
Apr 6, 2020

Conversation

acabarbaye
Copy link
Contributor

Description

Fix the problem with changelog generation which was due to this error in the underlying tool twisted/towncrier#180.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@codeclimate
Copy link

codeclimate bot commented Apr 6, 2020

Code Climate has analyzed commit 4ae3f43 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@rosiemiller2 rosiemiller2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know to keep an eye out for things like this. Thanks Adrien!

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #43 into master will not change coverage by %.
The diff coverage is 45.83%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files          26       26           
  Lines        1499     1499           
=======================================
  Hits          947      947           
  Misses        552      552           
Impacted Files Coverage Δ
mbed_tools_ci_scripts/report_third_party_ip.py 38.70% <27.27%> (ø)
mbed_tools_ci_scripts/tag_and_release.py 35.18% <44.44%> (ø)
mbed_tools_ci_scripts/_version.py 100.00% <100.00%> (ø)

@acabarbaye acabarbaye merged commit 6c9ab19 into master Apr 6, 2020
@acabarbaye acabarbaye deleted the fix-towncrier branch April 6, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants