DISCO STM32H747I ETHERNET support, but disabled. #11827
Conversation
|
@ABOSTM, thank you for your changes. |
|
Would be really nice to get a picture of the PWB that would highlight the resistors you need to modify. They're not that easy to find from there. |
|
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
|
@JanneKiiskila Pictures have been added to wiki page. |
features/netsocket/emac-drivers/TARGET_STM/TARGET_STM32H7/TARGET_DISCO_H747I/stm32h7_eth_init.c
Show resolved
Hide resolved
59dfb29 to
79fddba
Compare
|
With a modified board socket tests now pass. |
|
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
|
Ci failed due to error in this PR: Is this intentional, shouldn't there be a warning or how to report this to a user? |
|
This error is abnormal, it should be conditioned by the activation of ETHERNET connector. |
|
please check. It can be that our CI enabled ethernet to test it ? or this config comes from ST config and should not be present in our CI? |
Looking at build log: #define MBED_CONF_TARGET_NETWORK_DEFAULT_INTERFACE_TYPE ETHERNET // set by application[*] Is it set by CI .....? |
|
Seems that Ethernet could be configured in ? why...? |
|
That is how one gets the Ethernet tests to run. However, we have now two choices;
|
|
Oh Something like: |
|
Nope, that would not work either. That would try to make the test job look for a config file called "NONE", which would not exist. I think for now the easiest would be to patch the ethernet test config to add the target specific change. It's just a build test, so it would pass anyway. I.e. https://github.com/ARMmbed/mbed-os/blob/master/tools/test_configs/EthernetInterface.json
(Though I suppose theoretically you could add it even to all boards, it would do not harm there either.) @0xc0170 should advice here and/or @jamesbeyond as well - what do you recommend? (For the record, we have only 1 Ethernet modified H747I - we modified two, but only 1 works for some reason. Modification time is around 15 minutes per board, so I am not too inclined to do those en masse). |
|
There are still a few unused variable warnings, would be neat if we could fix them already now. Warning free code should be the target for everyone. |
|
Let's remove EMAC device_has! |
Ethernet is disabled by default, because some hardware modifications are required on the board DISCO_H747I. see https://os.mbed.com/teams/ST/wiki/DISCO_H747I-modifications-for-Ethernet
|
Wait.. Are you saying that somehow this application fetches a test configuration, even when not specified in That should not happen. It should be fine to have no test configuration. That is most common use case. |
79fddba to
7fcedd2
Compare
|
We finnaly decided to deactivate EMAC by default. By the way, I removed warning on unused variables. |
|
@SeppoTakalo - no it was a greentea test build or something. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
Moved to 5.15 due to dependencies on 5.15 changes |
Description
Add support of ethernet for DISCO_H747I,
Ethernet is disabled by default, because some hardware modifications are required on the board DISCO_H747I.
see https://os.mbed.com/teams/ST/wiki/DISCO_H747I-modifications-for-Ethernet
By default, all necessary DISCO_H747I MCU pins for ethernet are not connected ethernet controller (but instead are used for audio use cases). Consequently following modifications are requitred in order to use ethernet on DISCO_H747I:
Hardware:
Modify solder bridges and resistor as below (for details, refer to STM32H747I-DISCO board user manual https://www.st.com/resource/en/user_manual/dm00504240.pdf):
Software:
Create (or update) file 'mbed_app.json':
Pull request type
Test results
All tests 'netsocket...' are PASSED with IAR, GCC_ARM and ARM.