build: api-tests: cmake falls back to default host compiler

[microbuilder]

When building psa_arch_tests in Zephyr with TF-M, cmake falls back to the default C compiler, rather than forwarding the correct ARM cross-compiler, resulting in build failure.

The use of the host compiler is caused by this: https://github.com/ARM-software/psa-arch-tests/blob/master/api-tests/CMakeLists.txt#L415-L436

Where the compiler is not passed on, but a C compiler is being looked up here:
https://github.com/ARM-software/psa-arch-tests/blob/master/api-tests/tools/scripts/target_cfg/CMakeLists.txt#L29

# Let the CMake look for C compiler
project(TargetConfigGen LANGUAGES C)

To Reproduce

The twister command is part of Zephyr, but you can see the clang compiler being called as the default with this test suite:

$ ./scripts/twister -p mps2_an521_nonsecure -N --inline-logs \
  -s samples/tfm_integration/tfm_psa_test/sample.tfm.psa_internal_trusted_storage_test

This will result in trying to run the system C compiler (/Library/Developer/CommandLineTools/usr/bin/cc here, on OS X) instead of the toolchain that should be passed in (arm-none-eabi-gcc, arm-zephyr-eabi-gcc, etc.):

[2/5] Building C object CMakeFiles/TargetConfigGen.dir/Users/kevin/Linaro/zephyr/zephyr/twister-out/mps2_an521_nonsecure/samples/tfm_integration/tfm_psa_test/sample.tfm.psa_internal_trusted_storage_test/tfm/app/psa_api_tests/targetConfigGen.c.o
FAILED: CMakeFiles/TargetConfigGen.dir/Users/kevin/Linaro/zephyr/zephyr/twister-out/mps2_an521_nonsecure/samples/tfm_integration/tfm_psa_test/sample.tfm.psa_internal_trusted_storage_test/tfm/app/psa_api_tests/targetConfigGen.c.o 
/Library/Developer/CommandLineTools/usr/bin/cc  -I/Users/kevin/Linaro/zephyr/modules/tee/tfm/psa-arch-tests/api-tests/val/nspe -I/Users/kevin/Linaro/zephyr/modules/tee/tfm/psa-arch-tests/api-tests/val/common -I/Users/kevin/Linaro/zephyr/modules/tee/tfm/psa-arch-tests/api-tests/platform/targets/common/nspe -I/Users/kevin/Linaro/zephyr/modules/tee/tfm/psa-arch-tests/api-tests/platform/targets/common/nspe/crypto -I/Users/kevin/Linaro/zephyr/modules/tee/tfm/psa-arch-tests/api-tests/platform/targets/tgt_dev_apis_tfm_an521/nspe -arch arm64 -o CMakeFiles/TargetConfigGen.dir/Users/kevin/Linaro/zephyr/zephyr/twister-out/mps2_an521_nonsecure/samples/tfm_integration/tfm_psa_test/sample.tfm.psa_internal_trusted_storage_test/tfm/app/psa_api_tests/targetConfigGen.c.o -c /Users/kevin/Linaro/zephyr/zephyr/twister-out/mps2_an521_nonsecure/samples/tfm_integration/tfm_psa_test/sample.tfm.psa_internal_trusted_storage_test/tfm/app/psa_api_tests/targetConfigGen.c
/Users/kevin/Linaro/zephyr/zephyr/twister-out/mps2_an521_nonsecure/samples/tfm_integration/tfm_psa_test/sample.tfm.psa_internal_trusted_storage_test/tfm/app/psa_api_tests/targetConfigGen.c:1:10: fatal error: 'stdio.h' file not found
#include <stdio.h>
         ^~~~~~~~~

Expected behavior

The toolchain triplet (CROSS_COMPILE) should be passed in to the cmake ExternalProject when running the PSA tests so that the right compiler is called.

[jk-arm]

we will revisit this topic after july 11th as planned release activity psa arch test v1.2 on going

[jk-arm]

Currently working on unifying this requirement, the TS team also had a similar ask. We will communicate the final outcome. for time being let the commit be as it is. https://review.trustedfirmware.org/c/TS/trusted-services/+/10561/1 Regards, JK From: Prasanth Pulla ***@***.***> Sent: 14 July 2021 22:20 To: ARM-software/psa-arch-tests ***@***.***> Cc: Jothikumar Mani ***@***.***>; Comment ***@***.***> Subject: Re: [ARM-software/psa-arch-tests] build: api-tests: cmake falls back to default host compiler (#265) Closed #265<#265> via #268<#268>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#265 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBXKQU3B7DIRDXW2GWIPMLTXW53HANCNFSM44KEKKLQ>. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.